-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add theme override: menu item selected + hover #2598
Comments
The design is originally designed like this, which is more convenient for users to adjust. If you need to keep the hover and active colors the same, you can set these two variables to be the same. |
unless I'm mistaken, right now there is now way (using theme override) to have a different hover text/icon/etc color ONLY for the selected menu item: to give an example this is what I implemented using n-menu + custom css: when the menu item is selected the hover text/icon/etc should be a dark color (cause the selected menu item bg is light), when it's not selected, the opposite (cause the menu item bg is dark). BONUS would be nice to have a configurable hover bg like this as well |
yes but I need 2 different hover colors! I need a hover color for when I have the active bg and another hover color for when I don't have the active bg. |
yeah, maybe add new theme override props |
This is really a tough problem. How to define the theme variable name. We need some time to think. |
there already is Also. it'd be nice to have the term |
Active in naive ui is named as pressed. |
This function solves the problem (这个功能解决的问题)
To style the text/icon/etc when a menu item is selected differently than when it's not selected while the user is hovering on that item
Expected API (期望的 API)
add new theme override props like:
itemTextColorActiveHover
(don't forget the inverted variant!)
The text was updated successfully, but these errors were encountered: