Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including an unsupported scope in a limiter's scopes causes rate limiter to not be applied #4099

Open
cbruno10 opened this issue Jan 30, 2024 · 5 comments
Assignees
Labels
bug Something isn't working stale No recent activity has been detected on this issue/PR and it will be closed

Comments

@cbruno10
Copy link
Contributor

Describe the bug
If I add a limiter:

plugin "aws" {
  limiter "s3_limiter" {
    bucket_size = 50
    fill_rate   = 50
    scope       = ["connection", "service", "foo"]
    where       = "service = 's3'"
  }
}

Even if the tags are correct for the S3 tables, no rate limiters are applied due to the foo scope.

Similarly, if I add region, which is a valid scope for other tables, but not aws_s3_bucket, limiters won't be applied.

Steampipe version (steampipe -v)
v0.21.4

To reproduce
Add the limiter above and run this query to check if rate limiters are applied:

select jsonb_pretty(_ctx) from aws_s3_bucket limit 1

Expected behavior
An error should be raised letting me know that there's an invalid scope

Additional context
Add any other context about the problem here.

@cbruno10 cbruno10 added the bug Something isn't working label Jan 30, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Mar 31, 2024
Copy link

This issue was closed because it has been stalled for 90 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2024
@pskrbasu pskrbasu added needs reproduction Reproduction steps are not defined for this issue and removed needs reproduction Reproduction steps are not defined for this issue labels Jun 6, 2024
@pskrbasu pskrbasu reopened this Jun 14, 2024
@github-actions github-actions bot removed the stale No recent activity has been detected on this issue/PR and it will be closed label Jun 15, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Aug 14, 2024
Copy link

This issue was closed because it has been stalled for 90 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2024
@pskrbasu pskrbasu reopened this Sep 13, 2024
@pskrbasu pskrbasu removed the stale No recent activity has been detected on this issue/PR and it will be closed label Sep 13, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale No recent activity has been detected on this issue/PR and it will be closed
Projects
None yet
Development

No branches or pull requests

3 participants