Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgnoreConfig not working for ListConfig having a ParentHydrate #544

Open
karanpopat opened this issue Apr 14, 2023 · 1 comment
Open

IgnoreConfig not working for ListConfig having a ParentHydrate #544

karanpopat opened this issue Apr 14, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@karanpopat
Copy link

To Reproduce:

In table aws_wellarchitected_workload_share remove lines 153-156

if strings.Contains(err.Error(), "ResourceNotFoundException") || strings.Contains(err.Error(), "ValidationException") {
		plugin.Logger(ctx).Debug("aws_wellarchitected_workload_share.listWellArchitectedWorkloadShares", "checked_error", err)
		return nil, nil
}

then query

> select * from aws_wellarchitected_workload_share where status = 'PENDINGX'

Having the ignore config defined as

IgnoreConfig: &plugin.IgnoreConfig{
		ShouldIgnoreErrorFunc: shouldIgnoreErrors([]string{"ValidationException", "ResourceNotFoundException"}),
},

it should not be giving a ValidationException

@ParthaI
Copy link

ParthaI commented Aug 20, 2024

Furthermore, the connection-level ignore_error_codes configuration is also not functioning properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants