Skip to content
This repository has been archived by the owner on May 17, 2023. It is now read-only.

NoMethodError: undefined method `log_class_name=' for Playful:Module #16

Open
xam7247 opened this issue Aug 24, 2015 · 5 comments
Open

Comments

@xam7247
Copy link

xam7247 commented Aug 24, 2015

I believe log_switch gem has changed, causing playful gem to fail when requiring it:

require 'playful/ssdp'

throws:

NoMethodError: undefined method `log_class_name=' for Playful:Module

@MrJoy
Copy link

MrJoy commented Sep 12, 2015

... and once you fix that you run into the fact that in v. 1.0, log_switch no longer has LogSwitch::Mixin.

@turboladen
Copy link
Owner

playful should really lock down log_switch to '~> 0.4.0'.

@MrJoy
Copy link

MrJoy commented Sep 14, 2015

Updating playful to use the newer log_switch version was easy enough, although fully validating it was difficult because of the ether poor state of the various test suites.

I've forked the repo -- renamed to Frisky, pared the functionality back to basically just doing SSDP queries, updated the log_switch deep, etc. The functionality I clipped out, given the significant dependency surface area and less well-defined architecture, seems to be better suited to a gem built on top, rather than a big-ball-of-mud.

So if you just need the SSDP portion -- I.E. You tended to do "require 'playful/ssdp'", then my fork may be more suitable -- though I won't have time to deal with test suites until after my wedding in October.

Sent from my iPhone

On Sep 14, 2015, at 9:32 AM, Steve Loveless [email protected] wrote:

playful should really lock down log_switch to '~> 0.4.0'.


Reply to this email directly or view it on GitHub.

@turboladen
Copy link
Owner

Cool, glad playful at least gave you, @myjoy, some starting ground to something useful. I never released a release version of the gem because of that lack of tests; I release a pre-release version of the gem because I thought it might prove to be useful to someone and I knew I wasn't going to work on it anymore (work project at an old job).

@MrJoy
Copy link

MrJoy commented Sep 15, 2015

It was immensely helpful, so thank you!

Sent from my iPhone

On Sep 14, 2015, at 1:33 PM, Steve Loveless [email protected] wrote:

Cool, glad playful at least gave you some starting ground to something useful. I never released a release version of the gem because of that lack of tests; I release a pre-release version of the gem because I thought it might prove to be useful to someone and I knew I wasn't going to work on it anymore (work project at an old job).


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants