Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not schedule connection retry on dead eventloopgroup #2

Open
m0wfo opened this issue Dec 21, 2020 · 0 comments
Open

Do not schedule connection retry on dead eventloopgroup #2

m0wfo opened this issue Dec 21, 2020 · 0 comments

Comments

@m0wfo
Copy link
Collaborator

m0wfo commented Dec 21, 2020

ClientBootstrap.connectWithRetry(...) should check to see if the bootstrap's event loop group is still available for scheduling as it may have been shut down (e.g. by an int signal) between attempts. If the event loop is dead, no further retries should be attempted. Update documentation to make this clear.

This is to avoid the error:

ERROR: Cannot schedule tasks on an EventLoop that has already shut down. This will be upgraded to a forced crash in future SwiftNIO versions.

(plus backtrace when not compiled for release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant