[BUG] Login/Signup with Google with existing basic email/password account

[0xMurage]

Describe the bug:

Signup/Sign in with Google while one already has a basic password account with a similar email redirects the user to a blank page.

Expected Behavior

If I already have a basic password account, I should get logged in successfully (the system should merge existing user identity + mark account email as verified), or I should see account already exist error.

Current Behavior

The user is redirected to a blank callback page.

Steps to reproduce

1. Sign up with username/password/email form
2. Sign in with Google using the same email account used above

Error Log / Stack Trace (where applicable)

• /api/v1/oauth2s returns 200 OK status
• A 404 error (Wrong username or password) is returned on /api/v1/auth endpoint

Tell us about your browser and operating system:

• Operating System: Linux x64
• NodeJS Version:
• Ember Version:

Screenshots where applicable

[jim4067]

Perhaps we could add some form of validation in the back end to prevent double sign up if user already exists and a email already exists error/notification for the front end?

[jim4067]

also, what does the following code do?

wikonnect/server/routes/oauth2s.js

Lines 23 to 35 in ea3b4c4

	} catch (err) {
	if (err.constraint == 'users_email_unique') {
	let user = await User.query().where('email', newUser.email);
	delete user[0].hash;
	user = user[0];
	ctx.status = 200;
	ctx.body = { oauth2: user };
	} else {
	log.error(err);
	ctx.throw(err.status.code, null, { errors: [err.message] });
	}
	}
	});