Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for webRequest freeze #102

Open
Perflyst opened this issue Jul 17, 2019 · 2 comments
Open

Add support for webRequest freeze #102

Perflyst opened this issue Jul 17, 2019 · 2 comments
Labels

Comments

@Perflyst
Copy link

Currently it is only possible to block request but not possible to timeout a request.

A timeout is needed if a broken website or application re-tries until it succeeds. But if it is blocked it will never succeed and therefore will create endless requests which results in memory leaks and freezing firefox.

Example:

browser.webRequest.onBeforeRequest.addListener(async request => {
  console.log('incoming request', request);
  await new Promise(() => {});
}, {urls: ['https://www.domain.com/*']}, ['blocking']);
@tumpio tumpio added the feature label Aug 5, 2019
@tumpio
Copy link
Owner

tumpio commented Aug 5, 2019

Should there be a time limit after the frozen request times out?

@Perflyst
Copy link
Author

Perflyst commented Aug 5, 2019

This would may be useful, otherwise there will/can be a memory leak. If possible I would like to have the timeout time limit configureable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants