-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: order for XCLocalSwiftPackageReference
and XCRemoteSwiftPackageReference
#855
fix: order for XCLocalSwiftPackageReference
and XCRemoteSwiftPackageReference
#855
Conversation
d33d22f
to
b380040
Compare
XCLocalSwiftPackageReference
and XCRemoteSwiftPackageReference
So we are just fixing that we are creating the project the same way you would create if you change it from Xcode UI? Are we fixing an actual problem or it's just to be more consistent with it? |
There is no problem or bug. It's just to be consistent with how Xcode makes/arranges the project file. |
XCLocalSwiftPackageReference
and XCRemoteSwiftPackageReference
XCLocalSwiftPackageReference
and XCRemoteSwiftPackageReference
@pepicrft not sure why it fails on Linux but not macOS? |
@kimdv I could not reproduce it locally by running the tests through the Swift Docker image for version 5.10.1... So I decided to run the same script that one can run locally from macOS and that works fine. |
@all-contributor add @kimdv for code |
Short description 📝
In Xcode when writing to a project file, there was a diff in this example because it changed order.
This example above is how it looks when it's made with Xcode.
Solution 📦
The solution was pretty simple. Just move
XCLocalSwiftPackageReference
andXCRemoteSwiftPackageReference
around.Implementation 👩💻👨💻
Just switched the code around.