Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users should be able to add their own parameters #2

Open
tugh opened this issue Mar 13, 2017 · 8 comments
Open

Users should be able to add their own parameters #2

tugh opened this issue Mar 13, 2017 · 8 comments

Comments

@tugh
Copy link
Owner

tugh commented Mar 13, 2017

There should be a menu/settings page to let users to change the blocked parameters.

@atomGit
Copy link

atomGit commented Apr 13, 2017

hi - i saw you created this issue after a user commented on AMO that they were looking for a replacement for Pure URL - i'm in a similar boat in that my preferred cleaner, Clean Links, has apparently been abandoned

rather than create several new issues for features i'd like to see, i'll just list them here and you can decide if they fit in with your ideas...

Clean Links has 2 methods to white-list links that are both very handy - one uses reg. exp. that matches parts of URLs and is labeled 'Skip Links matching with' - the user can edit the expression - example:

www\.urlvoid\.com|login\.wordpress\.org|paypal\.com|whois\.domaintools\.com|webcitation\.org|iqdb\.org|translate\.google\.com|tinyurl\.com|tineye\.com|ServiceLogin|imgres\?|watch%3Fv|auth\?client_id|signup|bing\.com/widget|oauth|openid\.ns|\.mcstatic\.com|sVidLoc|[Ll]ogout|submit\?url=|magnet:

the other method skips entire domains and is a simple comma separated string - example:

accounts.google.com,archive.org,web.archive.org,wayback.archive.org,archive.is,docs.google.com,translate.google.com,www.virustotal.com,webcache.googleusercontent.com,accounts.youtube.com,signin.ebay.com,login.live.com,plus.google.com

then, as the AMO user commented, the params that get removed are editable - example:

(?:ref|aff)\w*|utm_\w+|(?:merchant|programme|media)ID

also what i have found highly useful is that Clean Links alters a links style (applies CSS) to cleaned links AND briefly changes the background color of the address bar when the link is loaded - this is visual indicator is super-useful in troubleshooting why a link is not working as expected

the address bar color happens every time it cleans a link that is loaded, but how the CSS is applied depends on what mode you have the extensions set to, 'normal' or 'event delegation' - in the latter mode, which is the default, Link Cleaner does not interfere with page load at all and doesn't do anything until a link is clicked, at which point it decides if it needs cleaned and, if so, applies the custom CSS - in the other mode, Link Cleaner parses all the links on the page during page load and applies the CSS

the 'normal' mode is ideal because it allows you to see immediately what links have been cleaned on the page before they are clicked, but i know the dev had problems getting it to work on pages with lots of links without severely impacting performance

another super-important feature of Link Cleaner was it's ability to clean links that are copied to the clipboard (works on Linux too)

Link Cleaner has several other features as well; a redirect watcher to catch 3xx redirections; HTTP observer; link tracking, which creates a list of cleaned links that can be used to easily whitelist stuff and a few more

maybe best to find the source for Link Cleaner if you're interested in these features - if you can't find it, i can upload the extension somewhere since it's no longer on AMO

@tugh
Copy link
Owner Author

tugh commented Apr 19, 2017

Thanks for your reply! Actually I wasn't aware of the Pure URL at the beginning and wasn't planning to replace Pure URL with this extension. This is just a personal project and will probably stay as is but I like some of the ideas that you've mentioned.

Here is a list of the ideas that I've liked:

  • URL whitelist (just a list at first, not regex)
  • Parameters list (just a list at first, not regex)
  • Address bar color change when removed one or more parameter

Cleaning all the links in a page may decrease performance as you mentioned. Cleaning the copied URL at the clipboard is just whole another level. It is a good feature of course but it is out of my context.

If you have any other feedback you are always welcome.

@Smile4ever
Copy link

Smile4ever commented May 18, 2017

@xmikro

Parameters list (just a list at first, not regex)

Please have a look at Translate Now. Would you like an option page like that? https://addons.mozilla.org/nl/firefox/addon/translate-now/

Address bar color change when removed one or more parameter

Currently not possible by using the WebExtensions API.

@Smile4ever
Copy link

I would like to let you know that I've created Neat URL which is a fork of Lean URL.

Neat URL contains a few improvements over Lean URL:

  • set your own URL parameters on the options page (to reach feature parity with Pure URL)
  • fixed for recent Firefox versions
  • a nice animation in the toolbar (can be changed or disabled)
  • domain-specific blocked parameters (to reach feature parity with Pure URL)

You can take a look at it here:
https://addons.mozilla.org/firefox/addon/neat-url/

I've created this fork because the original author didn't react on / merge my pull requests.

@tugh
Feel free to maintain Lean URL with code I use here:
https://github.com/Smile4ever/firefoxaddons/tree/master/Neat%20URL-webext

@tugh
Copy link
Owner Author

tugh commented Aug 24, 2017

Thanks for your enthusiasm to continue the development. Unfortunately I didn't have the time to look at your pull request and merge it. I think it is better if you continue the development on your fork because I don't have the time to maintain this repository. I will probably add some features but they won't be so many and I can't promise on anything. :)

Thanks again, @Smile4ever

@Smile4ever
Copy link

@tugh Thanks for your reply and your encouragement, that's very much appreciated. Could you add the link https://addons.mozilla.org/firefox/addon/neat-url/ to Neat URL in your README? That would be really awesome!

@tugh
Copy link
Owner Author

tugh commented Aug 24, 2017

@Smile4ever Check out the readme.

@Smile4ever
Copy link

@tugh Very well, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants