Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only read one websocket frame at a time #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lhns
Copy link

@lhns lhns commented Jun 16, 2020

This PR reworks the websocket read logic to read exactly one websocket frame from the tcp buffer for each loop iteration. This is done by first peeking at the tcp buffer to read the header to read the payload size. The previous implementation just read the whole buffer, decoded the first websocket frame and discarded the remaining buffer. This leads to problems when there are multiple websocket frames already in the buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant