Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it work with react native? #114

Closed
chrusart opened this issue Aug 3, 2018 · 3 comments
Closed

Does it work with react native? #114

chrusart opened this issue Aug 3, 2018 · 3 comments

Comments

@chrusart
Copy link

chrusart commented Aug 3, 2018

I can extract translations, merge .pot to .po, but can't make it work in RN.
Weird thing is that it only works when I debugging remotely in chrome and reading stored json files.
It doesn't work when I'm not connected to remote debugger, it has a problem as stored json files are stripped from Symbol types after JSON.stringify().

undefined is not a function (evaluating 'getObjectKeys(translateObj.translations)[typeof Symbol === "function" ? Symbol.iterator : "@@iterator"]()')
@chrusart
Copy link
Author

chrusart commented Aug 3, 2018

Ok, probably it has something to do with JavaScriptCore as it's outdated in Android.
Symbol is not in shipped in JSC for Android.
facebook/react-native#15902
facebook/react-native#5294 (comment)
Will post results when using new JSC for RN Android.

@chrusart
Copy link
Author

chrusart commented Aug 3, 2018

Ok, with new JSC works.
https://github.com/react-community/jsc-android-buildscripts
Binaries - yarn add jsc-android and just setup Andoid project.

@chrusart chrusart closed this as completed Aug 3, 2018
@AlexMost
Copy link
Member

AlexMost commented Aug 6, 2018

Hey @chrusart, sorry for the late reply. Thanks for the research - this can be really helpful. Feel free to report any issues or request a feature) Any feedback is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants