Exclude ctrl+tab from wrappers #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
This PR removes commands triggered by
ctrl+taborctrl+shift+tabfrom keybindings wrappers.They were causing issue #119.
It seems that the commands rely on the popup UI called Quick Pick.
Even if you simply want to switch to the next editor tab by
ctrl+tab, the menu opens, and when you release thectrlkey the focused item is selected and the selected tab opens.The behavior when releasing
ctrlseems to be built-in to Quick Pick.This extension cannot cover to record and playback navigations on Quick Pick UI. For example,
UpArrow/DownArrowto select items,Enter/Spaceto accept an item, are not handled by the Keybindings system of vscode. Thus, they are not able to be recorded or to playback by an extension.