Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify FileNode #22

Open
tshikaboom opened this issue Aug 25, 2020 · 0 comments
Open

Simplify FileNode #22

tshikaboom opened this issue Aug 25, 2020 · 0 comments

Comments

@tshikaboom
Copy link
Owner

This is more or less me writing down what #19 has made me remark about the state of class FileNode.

  • Simplify the class definition and its parsing (the header itself is one uint32_t only, use that to infer the FileNode's properties afterwards, and not explicitly store them as separate members
  • Move skip_node() to a place better suited for what this function does, like FileNodeListFragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tshikaboom