-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion - allow a reference to be set #17
Comments
Ultimately it should noty matter what reference you use, because the SNPs it generates are "core" only. But that said, it could still be useful. This project is very early stages, but I hope to work on it this month. |
Thanks for letting me know. I've currently made a bit of a quick workaround by just reversing the logic (making the reference be the smaller of the two sequences) and it seems to run fine. The other advantage of doing the analysis with different references is you get the regions present only in the reference from the uncov.bed (if I am understanding the output correctly) which can be useful for finding where phage etc might be integrated. Looking forward to the later stages when they come. |
It's important to realise I recently came across and packaged this new tool: https://github.com/hsinnan75/MapCaller As for |
One reason I'd like to specify a ref is faster processing of subclustering. A sample of interest specified as ref against a large panel enables the reuse of alignments with |
Ok, that's a good use case. Thank you! |
Hi - really liking the tool! One suggested improvement would be to have an option to control which of the sequences gets set as your reference rather than defaulting to the largest sequence. If there is a reason this is a bad idea please let me know. I had a look at the code and from what I could tell the determination of the reference is using the snippet below. The $biggest_size variable looked to be only used to decide the $ref_index so it should be possible to select a reference sequence as the $ref_idx if provided. I wasn't sure if any of the other tools required the reference to be the largest sequence though.
The main reason for this suggestion is for when there is a reference sequence that has better annotations/ phenotypic data so understanding what has changed in relation to that sequence is useful.
The text was updated successfully, but these errors were encountered: