From 1b9161d636db1041943a69256befd140f0a22098 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Sun, 25 Feb 2024 20:23:21 -0500 Subject: [PATCH] [Ember]: Set noEmitOnError to false --- bases/ember.json | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/bases/ember.json b/bases/ember.json index ed52f6c..cc0a146 100644 --- a/bases/ember.json +++ b/bases/ember.json @@ -48,10 +48,13 @@ "noPropertyAccessFromIndexSignature": true, // --- Compilation/integration settings - // Setting `noEmitOnError` here allows ember-cli-typescript to catch errors - // and inject them into Ember CLI's build error reporting, which provides - // nice feedback for when - "noEmitOnError": true, + // Setting `noEmitOnError` here allows tools trying to respect the tsconfig + // to still emit code without breaking on errors. + // Errors are still reported in the CLI when running `tsc` or `glint`, + // but the errors won't prevent code from being emitted. + // This helps hasten development by allowing devs to prototype before coming + // to a decision on what they want their types to be. + "noEmitOnError": false, // We use Babel for emitting runtime code, because it's very important that // we always and only use the same transpiler for non-stable features, in