Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase CMake Version #23

Closed
Squareys opened this issue Jan 17, 2018 · 1 comment
Closed

Increase CMake Version #23

Squareys opened this issue Jan 17, 2018 · 1 comment

Comments

@Squareys
Copy link
Contributor

Hi @asria!

I am using your docker image to compile a project based on magnum which supports emscripten builds through a cmake toolchain.

The toolchain requires at least CMake 3.7, though (https://github.com/mosra/toolchains/blob/master/generic/Emscripten-wasm.cmake#L48 for explanation), but the image only provides 3.6.

I already built a custom version of your image where I simply updated the cmake download link and that works great, but it would be amazing to not have to maintain that myself with every emscripten update.

Would you be okay with increasing the CMake version? Which version would you suggest (3.7/3.10)? I can provide a PR, if you're fine with it.

Thanks in advance and thanks for actively maintaining this docker image!
Cheers, Jonathan.

@trzecieu
Copy link
Owner

trzecieu commented Jan 17, 2018

Hi @Squareys,
I think that 3.7 will be a good choice. I'd be very grateful for a contribution, then it will be included to the new release.

Cheers,
Piotr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants