From d277817800e7399f97dbf42437ece6a2ef2cda8d Mon Sep 17 00:00:00 2001 From: "Mark A. Grondona" Date: Sun, 29 Mar 2020 15:53:08 +0000 Subject: [PATCH] shell: remove shell_svc_allowed from service callbacks Since shell services registered by flux_shell_service_register() are now secure by default, remove redundant calls to shell_svc_allowed() in message handlers in the input and output services. --- src/shell/input.c | 2 -- src/shell/output.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/shell/input.c b/src/shell/input.c index fe88cc4206ce..a2eab665154d 100644 --- a/src/shell/input.c +++ b/src/shell/input.c @@ -167,8 +167,6 @@ static void shell_input_stdin_cb (flux_t *h, bool eof = false; json_t *o; - if (shell_svc_allowed (in->shell->svc, msg) < 0) - goto error; if (flux_request_unpack (msg, NULL, "o", &o) < 0) goto error; if (iodecode (o, NULL, NULL, NULL, NULL, &eof) < 0) diff --git a/src/shell/output.c b/src/shell/output.c index c0e9594333e4..5dde7d1ca9ea 100644 --- a/src/shell/output.c +++ b/src/shell/output.c @@ -403,8 +403,6 @@ static void shell_output_write_cb (flux_t *h, json_t *o; json_t *entry; - if (shell_svc_allowed (out->shell->svc, msg) < 0) - goto error; if (flux_request_unpack (msg, NULL, "o", &o) < 0) goto error; if (iodecode (o, NULL, NULL, NULL, NULL, &eof) < 0)