-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Friendlier personal_sign message request #1694
Comments
@imsys can you provide test samples in text format? For us to test it easily. Thank for reporting this bug, we will look into it. |
@vikmeup , sure! I will create a test sample later today. |
There is a single page example here: Or if you prefer, the same html/js page as a gist: More info on personal_sign: |
It looks like a Trust Android issue, have you checked Trust iOS as well? |
@hewigovens I tested only on Android, I don't own an iOS device to test it. : P |
I just tested on iOS, it works nice there! |
Reported to android team, we will improve this in the upcoming releases. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
close for now, will update this when android app fixes this |
Is your feature request related to a problem? Please describe.
I'm developing an App, and I have only used used metamask for that. When using personal_sign there, I get a clean plaintext message that I can verify and know what I'm signing. But when I try to do the same in Trustwallet through WalletConnect, I get a hexadecimal that's really intimidating and scary, how could we be sure it is not asking to sign a transaction?
Describe the solution you'd like
If possible, I would want TrustWallet to show a friendlier personal_sign message
Describe alternatives you've considered
Alternative would be to let the user have to deal with it, or maybe only supporting metamask in the app.
Additional context
The text was updated successfully, but these errors were encountered: