Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Friendlier personal_sign message request #1694

Closed
imsys opened this issue Oct 10, 2021 · 10 comments
Closed

Feature request: Friendlier personal_sign message request #1694

imsys opened this issue Oct 10, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request no-issue-activity

Comments

@imsys
Copy link

imsys commented Oct 10, 2021

Is your feature request related to a problem? Please describe.
I'm developing an App, and I have only used used metamask for that. When using personal_sign there, I get a clean plaintext message that I can verify and know what I'm signing. But when I try to do the same in Trustwallet through WalletConnect, I get a hexadecimal that's really intimidating and scary, how could we be sure it is not asking to sign a transaction?

Describe the solution you'd like
If possible, I would want TrustWallet to show a friendlier personal_sign message

Describe alternatives you've considered
Alternative would be to let the user have to deal with it, or maybe only supporting metamask in the app.

Additional context
Selection_423

trustwalletsign

@vikmeup
Copy link
Contributor

vikmeup commented Oct 10, 2021

@imsys can you provide test samples in text format? For us to test it easily.

Thank for reporting this bug, we will look into it.

@imsys
Copy link
Author

imsys commented Oct 10, 2021

@vikmeup , sure! I will create a test sample later today.

@imsys
Copy link
Author

imsys commented Oct 10, 2021

There is a single page example here:
https://codepen.io/imsys/pen/qBXByvO

Or if you prefer, the same html/js page as a gist:
https://gist.github.com/imsys/2afacdd00961afa9994902cd298db16b

More info on personal_sign:
https://docs.metamask.io/guide/signing-data.html#a-brief-history
ethereum/go-ethereum#2940

@hewigovens
Copy link
Contributor

It looks like a Trust Android issue, have you checked Trust iOS as well?

@imsys
Copy link
Author

imsys commented Oct 11, 2021

@hewigovens I tested only on Android, I don't own an iOS device to test it. : P

@imsys
Copy link
Author

imsys commented Oct 22, 2021

I just tested on iOS, it works nice there!
So it is a Android only issue.
@hewigovens

trustwallet-ios-sign

@vikmeup
Copy link
Contributor

vikmeup commented Oct 22, 2021

I just tested on iOS, it works nice there! So it is a Android only issue. @hewigovens

trustwallet-ios-sign

Reported to android team, we will improve this in the upcoming releases.

@github-actions
Copy link

github-actions bot commented Nov 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@hewigovens
Copy link
Contributor

close for now, will update this when android app fixes this

@vcoolish
Copy link
Contributor

Thanks for report!
Will be fixed in next release
Screenshot 2021-11-20 at 13 00 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

No branches or pull requests

5 participants