Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support DID as service (actor) ID #1423

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

bstasyszyn
Copy link
Contributor

A service ID may be configured as a DID and the public key (used for HTTP signature verifications) may be configured as a key ID referencing a public key within the service's DID document.

closes #1113

Signed-off-by: Bob Stasyszyn [email protected]

@cla-bot cla-bot bot added the cla-signed label Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1423 (21915b1) into main (adb3687) will decrease coverage by 0.06%.
The diff coverage is 85.18%.

❗ Current head 21915b1 differs from pull request most recent head 7408cd4. Consider uploading reports for the commit 7408cd4 to get more accurate results

@@            Coverage Diff             @@
##             main    #1423      +/-   ##
==========================================
- Coverage   88.00%   87.93%   -0.07%     
==========================================
  Files         206      207       +1     
  Lines       19227    19517     +290     
==========================================
+ Hits        16920    17163     +243     
- Misses       1475     1501      +26     
- Partials      832      853      +21     
Impacted Files Coverage Δ
pkg/activitypub/resthandler/resthandler.go 89.47% <ø> (ø)
...vitypub/service/activityhandler/activityhandler.go 98.24% <ø> (ø)
pkg/activitypub/httpsig/algorithm.go 85.48% <50.00%> (ø)
cmd/orb-server/startcmd/params.go 82.09% <60.00%> (-0.13%) ⬇️
pkg/observer/observer.go 83.57% <66.66%> (-1.22%) ⬇️
cmd/orb-server/startcmd/start.go 68.37% <73.00%> (+0.51%) ⬆️
pkg/document/resolvehandler/resolvehandler.go 96.78% <75.00%> (-1.94%) ⬇️
pkg/discovery/endpoint/client/client.go 82.53% <81.15%> (-1.48%) ⬇️
pkg/activitypub/client/client.go 85.24% <83.05%> (-0.88%) ⬇️
pkg/discovery/endpoint/restapi/operations.go 88.60% <83.33%> (+0.38%) ⬆️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

A service ID may be configured as a DID and the public key (used for HTTP signature verifications) may be configured as a key ID referencing a public key within the service's DID document.

closes trustbloc#1113

Signed-off-by: Bob Stasyszyn <[email protected]>
@bstasyszyn bstasyszyn merged commit 13404e0 into trustbloc:main Aug 12, 2022
@bstasyszyn bstasyszyn deleted the 1113-7 branch August 12, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DID-based actor identifiers
2 participants