Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip UNC paths when running hook commands on Windows. #891

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Strip UNC paths when running hook commands on Windows. #891

merged 3 commits into from
Oct 28, 2024

Conversation

bicarlsen
Copy link
Contributor

Resolves Issue #889.

@ctron
Copy link
Collaborator

ctron commented Oct 25, 2024

Thanks for the PR. I just checked and we seem to have dunce already in the project's list of dependencies. Why not use it directly?

@bicarlsen
Copy link
Contributor Author

Thanks for the PR. I just checked and we seem to have dunce already in the project's list of dependencies. Why not use it directly?

Awesome. I missed that it was already included.

@ctron ctron merged commit 91b042b into trunk-rs:main Oct 28, 2024
60 checks passed
@ctron ctron mentioned this pull request Oct 28, 2024
Closed
@bicarlsen bicarlsen deleted the bug/windows_hooks branch October 28, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bicarlsen @ctron