From a2c376623ff45e4baa4321097585fdbfc82a1539 Mon Sep 17 00:00:00 2001 From: Duc Trung Le Date: Thu, 31 Aug 2023 21:40:10 +0200 Subject: [PATCH] Refactor VoilaApp --- packages/voila/src/app.ts | 6 +++--- packages/voila/src/plugins/widget.ts | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/voila/src/app.ts b/packages/voila/src/app.ts index 3e1c7ea67..f06399f2e 100644 --- a/packages/voila/src/app.ts +++ b/packages/voila/src/app.ts @@ -40,7 +40,7 @@ export class VoilaApp extends JupyterFrontEnd { /** * The name of the application. */ - readonly name = 'Voila'; + readonly name: string = 'Voila'; /** * A namespace/prefix plugins may use to denote their provenance. @@ -136,8 +136,8 @@ export class VoilaApp extends JupyterFrontEnd { return this._widgetManager; } - private _widgetManager: KernelWidgetManager | null = null; - private _widgetManagerPromise = new PromiseDelegate(); + protected _widgetManager: KernelWidgetManager | null = null; + protected _widgetManagerPromise = new PromiseDelegate(); } /** diff --git a/packages/voila/src/plugins/widget.ts b/packages/voila/src/plugins/widget.ts index bddab5804..59d579318 100644 --- a/packages/voila/src/plugins/widget.ts +++ b/packages/voila/src/plugins/widget.ts @@ -117,7 +117,6 @@ export const renderOutputsPlugin: JupyterFrontEndPlugin = { const cellOutputs = document.body.querySelectorAll( 'script[type="application/vnd.voila.cell-output+json"]' ); - cellOutputs.forEach(async (cellOutput) => { const model = JSON.parse(cellOutput.innerHTML);