diff --git a/ui-tests/tests/voila.test.ts b/ui-tests/tests/voila.test.ts index 7a6ed5fe2..0299c5a80 100644 --- a/ui-tests/tests/voila.test.ts +++ b/ui-tests/tests/voila.test.ts @@ -4,8 +4,8 @@ import { expect, test } from '@playwright/test'; import { addBenchmarkToTest } from './utils'; -const PREFIX = - process.env.PROGRESSIVE_RENDERING === 'true' ? 'progressive_rendering_' : ''; +const PROGRESSIVE_RENDERING = process.env.PROGRESSIVE_RENDERING === 'true'; +const PREFIX = PROGRESSIVE_RENDERING ? 'progressive_rendering_' : ''; test.describe('Voila performance Tests', () => { test.beforeEach(({ page }) => { page.setDefaultTimeout(120000); @@ -310,9 +310,15 @@ test.describe('Voila performance Tests', () => { const notebookName = 'query-strings'; const testFunction = async () => { await page.goto(`/voila/render/${notebookName}.ipynb`); - await page.waitForSelector( - 'div.lm-Widget[data-mime-type="application/vnd.jupyter.stdout"]' - ); + if (PROGRESSIVE_RENDERING) { + await page.waitForSelector( + 'div.lm-Widget[data-mime-type="application/vnd.jupyter.stdout"]' + ); + } else { + await page.waitForSelector( + 'div.jp-OutputArea-output[data-mime-type="text/plain"]' + ); + } const userName = await page.$$( 'div.jp-RenderedText.jp-OutputArea-output > pre' ); diff --git a/ui-tests/tests/voila.test.ts-snapshots/bokeh-linux.png b/ui-tests/tests/voila.test.ts-snapshots/bokeh-linux.png index e5fda33b9..3cdd25e63 100644 Binary files a/ui-tests/tests/voila.test.ts-snapshots/bokeh-linux.png and b/ui-tests/tests/voila.test.ts-snapshots/bokeh-linux.png differ diff --git a/ui-tests/tests/voila.test.ts-snapshots/gridspecLayout-linux.png b/ui-tests/tests/voila.test.ts-snapshots/gridspecLayout-linux.png index eb77fc2a5..d8950e4f5 100644 Binary files a/ui-tests/tests/voila.test.ts-snapshots/gridspecLayout-linux.png and b/ui-tests/tests/voila.test.ts-snapshots/gridspecLayout-linux.png differ diff --git a/ui-tests/tests/voila.test.ts-snapshots/ipympl-linux.png b/ui-tests/tests/voila.test.ts-snapshots/ipympl-linux.png index 5b93301dc..adfea8303 100644 Binary files a/ui-tests/tests/voila.test.ts-snapshots/ipympl-linux.png and b/ui-tests/tests/voila.test.ts-snapshots/ipympl-linux.png differ diff --git a/ui-tests/tests/voila.test.ts-snapshots/voila-tree-classic-linux.png b/ui-tests/tests/voila.test.ts-snapshots/voila-tree-classic-linux.png index 62320aaea..c7df7f70f 100644 Binary files a/ui-tests/tests/voila.test.ts-snapshots/voila-tree-classic-linux.png and b/ui-tests/tests/voila.test.ts-snapshots/voila-tree-classic-linux.png differ diff --git a/ui-tests/tests/voila.test.ts-snapshots/voila-tree-dark-linux.png b/ui-tests/tests/voila.test.ts-snapshots/voila-tree-dark-linux.png index 833bd75d1..158400b58 100644 Binary files a/ui-tests/tests/voila.test.ts-snapshots/voila-tree-dark-linux.png and b/ui-tests/tests/voila.test.ts-snapshots/voila-tree-dark-linux.png differ diff --git a/ui-tests/tests/voila.test.ts-snapshots/voila-tree-light-linux.png b/ui-tests/tests/voila.test.ts-snapshots/voila-tree-light-linux.png index c082fa0f2..0a95bca04 100644 Binary files a/ui-tests/tests/voila.test.ts-snapshots/voila-tree-light-linux.png and b/ui-tests/tests/voila.test.ts-snapshots/voila-tree-light-linux.png differ