Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Consider using solc-js and not a copy called solcWrap #1426

Closed
axic opened this issue Nov 13, 2018 · 1 comment
Closed

Consider using solc-js and not a copy called solcWrap #1426

axic opened this issue Nov 13, 2018 · 1 comment

Comments

@axic
Copy link
Contributor

axic commented Nov 13, 2018

This piece of code seems to be an extract from solc-js:
https://github.com/trufflesuite/truffle/blob/next/packages/truffle-compile/solcWrap.js

Based on the change history, it seems it was introduced to speed up the load time: 729996d

The real solution would be to use require('solc/wrapper') which accomplishes the same.

The main reason the current approach is broken: 0.5.0 introduced a lot of changes, all of which are hidden by solc-js. If you update to solc-js 0.5.0, then it will work, but with the current wrapper, any new release won't be supported by truffle.

@axic axic changed the title Consider using solc-js and not copy called solcWrap Consider using solc-js and not a copy called solcWrap Nov 13, 2018
@gnidan
Copy link
Contributor

gnidan commented Nov 15, 2018

Thanks for opening this issue @axic. On it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants