OpenZepplin-Solidity tests fail after the State Trie and VM refactor

[davidmurdoch]

Even with the fix in 4a641cd openzeppelin-solidity tests as of commit https://github.com/OpenZeppelin/openzeppelin-solidity/tree/70e616db7c2bcce9d3a3fbbab83b7fe64a54fcd1 fail.

Original refactor commit: 56153af

1891 passing (6m)
  1 pending
  2 failing

  1) Contract: balanceDifference
       returns balance increments:

      AssertionError: expected '422589324399999999999' to equal '1000000000000000000'
      + expected - actual

      -422589324399999999999
      +1000000000000000000
      
      at Context.<anonymous> (test/helpers/test/balanceDifference.test.js:14:27)                                                                                                                                    
      at process._tickCallback (internal/process/next_tick.js:68:7)                                                                                                                                                 

[nventuro]

Hey, @nventuro from OpenZeppelin here, trying to fix that very same test while migrating to truffle 5. Does this issue being open mean the error was not fixed in the 2.3.2 release? Thanks!

[nventuro]

I've updated openzeppelin-test-helpers (where this functionality has been extracted to) to use ganache-core 2.3.3 (via ganache-cli 6.2.5), which made that very same test pass, so I think this can be closed.

[davidmurdoch]

Thanks @nventuro for following up on this. I'm going to keep this open until we can open until we can look into 56153af a bit further to see what originally went wrong in that commit and then file an appropriate issue for that when we do.

[davidmurdoch]

Closing this one for issue maintenance, as Ganache has been rewritten since this issue was first opened.