Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CP syntax, cleanup, formatting #70

Merged
merged 1 commit into from
Apr 21, 2015
Merged

New CP syntax, cleanup, formatting #70

merged 1 commit into from
Apr 21, 2015

Conversation

mike-north
Copy link
Owner

  • Switched us over to the new computed property syntax introduced in ember 1.12 - https://github.com/stefanpenner/rfcs/blob/ae07e7b1ce1996686c91250ebb2158a4eff4bce0/0000-improved-cp-syntax.md
  • Found a few places where this._super(...arguments) was not called in willDestroyElement, didInsertElement, or init hook
  • TODO'd some places where we're likely setting up listeners via materialize JavaScript on didInsertElement, and not properly tearing them down in willDestroyElement
  • More ES6ification: converted string concatination to template strings, callbacks to arrow functions, etc...

sgasser pushed a commit that referenced this pull request Apr 21, 2015
New CP syntax, cleanup, formatting
@sgasser sgasser merged commit 841fadd into mike-north:master Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants