Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal #65

Merged
merged 9 commits into from
Apr 17, 2015
Merged

Modal #65

merged 9 commits into from
Apr 17, 2015

Conversation

mike-north
Copy link
Owner

Work in progress. Please feel free to give feedback, but do not merge.

This is an implementation of the materialize dialog, build on top of ember-modal-dialog. The magic behind this is ember-wormhole which lets us render views into arbitrary DOM elements.

In the case of this dialog, it means that the dialog can be a direct decendant of the <body> element, getting us around some annoying stacking context issues.

{{#if modalIsOpen}}
  {{#materialize-modal close='closeModal'}}
    <div class="modal-content">
      <h4>Hello Modal</h4>
      <p>Oh hai there!</p>
    </div>
    <div class="modal-footer">
      <a class=" modal-action modal-close waves-effect waves-green btn-flat" {{action 'agree'}}>Agree</a>
      <a class=" modal-action modal-close waves-effect waves-green btn-flat" {{action 'closeModal'}}>Cancel</a>
    </div>
  {{/materialize-modal}}
{{/if}}

screen shot 2015-04-15 at 8 10 07 pm

@mike-north mike-north changed the title WIP - Modal Modal Apr 16, 2015
@mike-north
Copy link
Owner Author

Ready for review/merge

sgasser pushed a commit that referenced this pull request Apr 17, 2015
Merge pull request #65 from truenorth/modal
23501fa 
Modal
@sgasser sgasser merged commit 23501fa into mike-north:master Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-north @sgasser