Remove all instances of bind-attr #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to update Ember for this... I'm not sure if that should be in a separate PR. |
|
So this ends up removing support for ember 1.10 |
| - EMBER_TRY_SCENARIO=ember-1.11 | ||
| - EMBER_TRY_SCENARIO=ember-1.12 | ||
| - EMBER_TRY_SCENARIO=ember-1.13 |
Merged
|
please rebase |
Merged
Why: * `bind-attr` handlebars helper has been deprecated. This PR: * Replaces instances of `bind-attr` with their htmlbars counterpart
MattMSumner
force-pushed
the
mms-remove-bind-attr
branch
from
bb94f17 to
9b0fbf3
Compare
|
Done! Mind giving it another once over? |
|
|
Thanks for helping out!
mike-north
added a commit
that referenced
this pull request
Jul 11, 2015
Remove all instances of bind-attr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
bind-attrhandlebars helper has been deprecated.This PR:
bind-attrwith their htmlbars counterpart