Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create components for cards #15

Merged
merged 4 commits into from
Mar 18, 2015
Merged

create components for cards #15

merged 4 commits into from
Mar 18, 2015

Conversation

rynam0
Copy link
Contributor

@rynam0 rynam0 commented Mar 17, 2015

@sgasser As promised, here's a PR for card components. Please let me know what you think and if this is good for now, I'll start thinking about what to do next.

@sgasser
Copy link
Collaborator

sgasser commented Mar 17, 2015

Is there a reason why you add a blank line between each property inside the components?

@rynam0
Copy link
Contributor Author

rynam0 commented Mar 17, 2015

I find it easier to read in larger files. I can change that if you'd prefer.

@sgasser
Copy link
Collaborator

sgasser commented Mar 17, 2015

Inside the other files there is nowhere a blank line and also the documentation of ember is without so I prefer without blank line. Thanks

@rynam0
Copy link
Contributor Author

rynam0 commented Mar 17, 2015

Will do

@sgasser
Copy link
Collaborator

sgasser commented Mar 17, 2015

I fixed the problem with 'undefined' is not a function (evaluating '$(".button-collapse").sideNav()').
Please fetch the newest commit in your fork.

@rynam0
Copy link
Contributor Author

rynam0 commented Mar 17, 2015

Looks like i have a test to fix too

@sgasser
Copy link
Collaborator

sgasser commented Mar 18, 2015

Can you fix the test?

@rynam0
Copy link
Contributor Author

rynam0 commented Mar 18, 2015

I'm not sure. I've had no luck after a few hours of trying to figure something out. It seems that I just can't get the style attribute added for the transform when running with phantomJS. If you have any ideas I'd love to hear therm.

@rynam0
Copy link
Contributor Author

rynam0 commented Mar 18, 2015

I've tried to get this working in phantomJS but no matter what I try, it seems the velocity animation doesn't occur. I've tried sending the event 'click.card' in cards.js from materializecss, i've tried the click test helper, all of which work in chrome but not in phantomJS. I'm at a loss at this point so its your call whether you want to merge this in or not.

sgasser pushed a commit that referenced this pull request Mar 18, 2015
create components for cards
@sgasser sgasser merged commit 53fa063 into mike-north:master Mar 18, 2015
@sgasser
Copy link
Collaborator

sgasser commented Mar 18, 2015

New version v0.4.0 released.
Demo is online

@rynam0
Copy link
Contributor Author

rynam0 commented Mar 19, 2015

That test was driving me nuts and i've finally determined that it was the lack of Function.prototype.bind in phantomJS < 2.x. Adding the following polyfill to tests/index.html fixes the test.

<script>
  // PhantomJS doesn't support bind until 2.x
  // once upgraded to 2.x, this should be removed.
  Function.prototype.bind = Function.prototype.bind || function (thisp) {
    var fn = this;
    return function () {
      return fn.apply(thisp, arguments);
    };
  };
</script>

This will also be needed should someone work on moving components to the addon directory. I'll probably run with it and submit another PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants