-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create components for cards #15
Conversation
Is there a reason why you add a blank line between each property inside the components? |
I find it easier to read in larger files. I can change that if you'd prefer. |
Inside the other files there is nowhere a blank line and also the documentation of ember is without so I prefer without blank line. Thanks |
Will do |
I fixed the problem with |
merge fix for navbar - 63987e1
Looks like i have a test to fix too |
Can you fix the test? |
I'm not sure. I've had no luck after a few hours of trying to figure something out. It seems that I just can't get the style attribute added for the transform when running with phantomJS. If you have any ideas I'd love to hear therm. |
I've tried to get this working in phantomJS but no matter what I try, it seems the velocity animation doesn't occur. I've tried sending the event 'click.card' in cards.js from materializecss, i've tried the click test helper, all of which work in chrome but not in phantomJS. I'm at a loss at this point so its your call whether you want to merge this in or not. |
That test was driving me nuts and i've finally determined that it was the lack of Function.prototype.bind in phantomJS < 2.x. Adding the following polyfill to tests/index.html fixes the test.
This will also be needed should someone work on moving components to the addon directory. I'll probably run with it and submit another PR for this. |
@sgasser As promised, here's a PR for card components. Please let me know what you think and if this is good for now, I'll start thinking about what to do next.