Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple arrays #74

Closed
btecu opened this issue Apr 21, 2015 · 4 comments · Fixed by #78
Closed

Simple arrays #74

btecu opened this issue Apr 21, 2015 · 4 comments · Fixed by #78

Comments

@btecu
Copy link

btecu commented Apr 21, 2015

Select, radio buton and more seem to be broken if your content is a simple array of strings.

Although optionValuePath and optionLabelPath should be optional, it seems it doesn't work that way.

@mike-north
Copy link
Owner

I have added test coverage for the use cases you outline. The only bug I found was in {{md-select}}, and the workaround in the current version is to explicitly specify "content" as value and label paths

{{md-select
   content=choices
   value=selectedChoice
   optionValuePath='content'
   optionLabelPath='content'}}

@btecu
Copy link
Author

btecu commented Apr 24, 2015

Is it possible to make those optional similar to {{view 'select'}}?
I remember having the same issue with radio button - if you can't reproduce, I'll try to put an example.

@mike-north
Copy link
Owner

@btecu that's exactly what my PR #78 adds support for, although I found that the checkboxes, radios and switches already do what you're asking.

@btecu
Copy link
Author

btecu commented Apr 24, 2015

Awesome! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants