md-checks optionLabelPath appears dysfunctional

[joshpfosi]

I am using this component as

      {{md-checks
        selection=selectedLessons
        content=lessons
        optionValuePath="content"
        optionLabelPath="content.title"
        disabled=school.isLaunched}}

and the optionLabelPath is being completely ignored. The relevant lesson model is:

import DS from 'ember-data';

export default DS.Model.extend({
  title:             DS.attr('string')
});

[joshpfosi]

I solved this by changing optionValuePath to "content.content". This is b/c in

     // addon/components/selectable-item-group.js
      if (valuePath && labelPath) {
        return Ember.A(
          map(content, el => {
            return {value: get(el, valuePath), label: get(el, labelPath)};
          })
        );
      } else {
        return Ember.A(
          map(content, el => {
            return {value: el, label: el};
          })
        );
      }

if valuePath is not set, the labelPath is ignored. I think a second clause should be added to the conditional, namely:

else if (labelPath) {
   return Ember.A(
      map(content, el => { 
        return { value: el, label: get(el, labelPath) };
      });
   );
}

or this requirement could be documented! Sorry for the confusion!

[mike-north]

@joshpfosi with your example model, there's an implicit id attribute. I'd expect you to use this as your valuePath, and title as your labelPath

      {{md-checks
        selection=selectedLessons
        content=lessons
        optionValuePath="content.id"
        optionLabelPath="content.title"
        disabled=school.isLaunched}}

We're aiming for alignment with Ember.Select, which takes the same parameters. If you find a situation where Ember.Select works and {{md-checks}} does not, please let me know and I'll look into it

[joshpfosi]

I see. That makes sense. Thanks for the clarification :)