Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions can not be passed to SelectableItem sub classes #102

Closed
kvnn opened this issue May 7, 2015 · 3 comments
Closed

Actions can not be passed to SelectableItem sub classes #102

kvnn opened this issue May 7, 2015 · 3 comments

Comments

@kvnn
Copy link

kvnn commented May 7, 2015

An action is not fired If I try to do something like:

{{md-switch checked=switchValue onLabel="Sell" offLabel="Buy" action="toggleTradeMode"}}

I've added a few lines of code to fix this. If you approve of the feature & the method, I'll be happy to follow the contribution guidelines and submit a PR. Please let me know :D

Change: master...kvnn:patch-1

@sgasser
Copy link
Collaborator

sgasser commented May 25, 2015

You don't need a action.
You can observe the value to know if is checked or not.

@mike-north
Copy link
Owner

You can use data binding as @sgasser says, but it would be nice to fire an action as well. Let's leave this ticket open so I remember to add it in the future :)

@mike-north
Copy link
Owner

@kvnn check boxes, switches and radio buttons now should fire 'action' whenever their state is changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants