Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving LiteFullNodeTest test cases to plugins module #5380

Closed
forfreeday opened this issue Jul 28, 2023 · 4 comments
Closed

Moving LiteFullNodeTest test cases to plugins module #5380

forfreeday opened this issue Jul 28, 2023 · 4 comments
Assignees

Comments

@forfreeday
Copy link
Contributor

forfreeday commented Jul 28, 2023

Rationale

Since LiteFullNode function has been moved to the plugins module as DbLite, and the corresponding test cases should be grouped into the plugins block. Moving test cases to the plugins module also improves the efficiency of test case execution. The test cases in the framework and plugins modules run in parallel.

Implementation

1. Adding dependencies

Add a dependency to the build.gradle of the plugins module.

testCompile project(":framework")
testCompile project(":framework").sourceSets.test.output

2. Moving test cases around

Move the org/tron/program/LiteFullNodeToolTest.java test case from the framework module to the plugins module and rename it to org/tron/plugins/DbLiteTest.java.

@jwrct
Copy link
Contributor

jwrct commented Jul 31, 2023

Improving the efficiency of test cases sounds great. I feel that the current execution time of test cases is relatively long. May I ask, how much time can be saved by this operation?

@forfreeday
Copy link
Contributor Author

forfreeday commented Aug 3, 2023

This saves about 3 minutes because the LiteFullNodeTest test cases are executed in parallel in the plugins module.
Previously, compiling and executing test cases on a 16-core machine with 32GB of RAM took about 14m 53s

@endiaoekoe
Copy link

A Little curiours about why you want to seperate this LiteFullNodeTest test cases to other place? does it have any bad effects to current ?

@forfreeday
Copy link
Contributor Author

@mikeluxue
Because the current test cases are executed serially, the execution time is long. Moving to other modules allows you to execute the test cases in parallel, node the execution time of the test cases, and improve the efficiency of executing the test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants