From 0e51bf01ee30e5e917526f502f14507cd2399fdb Mon Sep 17 00:00:00 2001 From: Pieter Wigboldus Date: Mon, 18 Dec 2023 22:16:03 +0100 Subject: [PATCH 1/3] Fix test linting --- src/__tests__/enum.test.js | 526 +++++++++++++++++++------------------ 1 file changed, 271 insertions(+), 255 deletions(-) diff --git a/src/__tests__/enum.test.js b/src/__tests__/enum.test.js index 693b976..6d2f44c 100644 --- a/src/__tests__/enum.test.js +++ b/src/__tests__/enum.test.js @@ -1,284 +1,300 @@ -import test from 'node:test' -import assert from 'node:assert' -import { Enum } from '../enum.js' +import test from 'node:test'; +import assert from 'node:assert'; +import { Enum } from '../enum.js'; class Encoding extends Enum { - static 'utf-8' = 'UTF-8' + static 'utf-8' = 'UTF-8'; } test('Test the encoding enum', async (t) => { - await t.test('It should work with the default enum', () => { - assert.strictEqual(Enum.hasKey('test'), false) - assert.strictEqual(Enum.hasValue('test'), false) - assert.deepEqual(Enum.options, {}) - }) + await t.test('It should work with the default enum', () => { + assert.strictEqual(Enum.hasKey('test'), false); + assert.strictEqual(Enum.hasValue('test'), false); + assert.deepEqual(Enum.options, {}); + }); - await t.test('It should create from a key', () => { - const encoding = Encoding.fromKey('utf-8') - assert.strictEqual(encoding.key, 'utf-8') - assert.strictEqual(encoding.value, 'UTF-8') - assert.deepEqual(encoding.values, ['UTF-8']) - assert.deepEqual(Encoding.options, { - 'utf-8': 'UTF-8' - }) - assert.strictEqual(Encoding.options['utf-8'], 'UTF-8') - assert.deepEqual(encoding.keys, ['utf-8']) - assert.strictEqual(encoding['utf-8'], 'UTF-8') - assert.strictEqual(encoding.length, 1) - assert.strictEqual(encoding.is(Encoding['utf-8']), true) - assert.strictEqual(encoding.is('UTF-8'), true) - assert.strictEqual(encoding.is('something'), false) - assert.strictEqual(encoding.in([Encoding['utf-8']]), true) - assert.strictEqual(encoding.in(['UTF-8']), true) - assert.strictEqual(encoding.in(['something']), false) - assert.strictEqual(encoding.name, 'Encoding') - }) + await t.test('It should create from a key', () => { + const encoding = Encoding.fromKey('utf-8'); + assert.strictEqual(encoding.key, 'utf-8'); + assert.strictEqual(encoding.value, 'UTF-8'); + assert.deepEqual(encoding.values, ['UTF-8']); + assert.deepEqual(Encoding.options, { + 'utf-8': 'UTF-8', + }); + assert.strictEqual(Encoding.options['utf-8'], 'UTF-8'); + assert.deepEqual(encoding.keys, ['utf-8']); + assert.strictEqual(encoding['utf-8'], 'UTF-8'); + assert.strictEqual(encoding.length, 1); + assert.strictEqual(encoding.is(Encoding['utf-8']), true); + assert.strictEqual(encoding.is('UTF-8'), true); + assert.strictEqual(encoding.is('something'), false); + assert.strictEqual(encoding.in([Encoding['utf-8']]), true); + assert.strictEqual(encoding.in(['UTF-8']), true); + assert.strictEqual(encoding.in(['something']), false); + assert.strictEqual(encoding.name, 'Encoding'); + }); - await t.test('It should create from an value', () => { - const encoding = Encoding.fromValue('UTF-8') - assert.strictEqual(encoding.key, 'utf-8') - assert.strictEqual(encoding.value, 'UTF-8') - assert.deepEqual(encoding.values, ['UTF-8']) - assert.deepEqual(Encoding.options, { - 'utf-8': 'UTF-8' - }) - assert.deepEqual(encoding.keys, ['utf-8']) - assert.strictEqual(encoding['utf-8'], 'UTF-8') - assert.strictEqual(encoding.length, 1) - }) + await t.test('It should create from an value', () => { + const encoding = Encoding.fromValue('UTF-8'); + assert.strictEqual(encoding.key, 'utf-8'); + assert.strictEqual(encoding.value, 'UTF-8'); + assert.deepEqual(encoding.values, ['UTF-8']); + assert.deepEqual(Encoding.options, { + 'utf-8': 'UTF-8', + }); + assert.deepEqual(encoding.keys, ['utf-8']); + assert.strictEqual(encoding['utf-8'], 'UTF-8'); + assert.strictEqual(encoding.length, 1); + }); - await t.test('It should work with the static methods', () => { - assert.strictEqual(Encoding.hasKey('utf-8'), true) - assert.strictEqual(Encoding.hasKey('UTF-8'), false) - assert.strictEqual(Encoding.hasValue('UTF-8'), true) - assert.strictEqual(Encoding.hasValue('utf-8'), false) - }) + await t.test('It should work with the static methods', () => { + assert.strictEqual(Encoding.hasKey('utf-8'), true); + assert.strictEqual(Encoding.hasKey('UTF-8'), false); + assert.strictEqual(Encoding.hasValue('UTF-8'), true); + assert.strictEqual(Encoding.hasValue('utf-8'), false); + }); - await t.test('It should throw an exception for an unknown key', () => { - try { - Encoding.fromKey('UTF-8') - } catch (error) { - assert.strictEqual(error.message, 'Invalid Encoding key UTF-8') - } - }) + await t.test('It should throw an exception for an unknown key', () => { + try { + Encoding.fromKey('UTF-8'); + } catch (error) { + assert.strictEqual(error.message, 'Invalid Encoding key UTF-8'); + } + }); - await t.test('It should throw an exception for an unknown value', () => { - try { - Encoding.fromValue('utf-8') - } catch (error) { - assert.strictEqual(error.message, 'Invalid Encoding value utf-8') - } - }) + await t.test('It should throw an exception for an unknown value', () => { + try { + Encoding.fromValue('utf-8'); + } catch (error) { + assert.strictEqual(error.message, 'Invalid Encoding value utf-8'); + } + }); - await t.test('It should handle reserved word key', () => { - class Example extends Enum { - static key = 1 - } - const example = Example.fromKey('key') + await t.test('It should handle reserved word key', () => { + class Example extends Enum { + static key = 1; + } + const example = Example.fromKey('key'); - assert.strictEqual(example.key, 'key') - assert.strictEqual(example.value, 1) - assert.deepEqual(example.values, [1]) - assert.deepEqual(Example.options, { - key: 1 - }) - assert.deepEqual(example.keys, ['key']) - assert.strictEqual(example.key, 'key') - assert.strictEqual(example.length, 1) - assert.strictEqual(example.name, 'Example') - }) + assert.strictEqual(example.key, 'key'); + assert.strictEqual(example.value, 1); + assert.deepEqual(example.values, [1]); + assert.deepEqual(Example.options, { + key: 1, + }); + assert.deepEqual(example.keys, ['key']); + assert.strictEqual(example.key, 'key'); + assert.strictEqual(example.length, 1); + assert.strictEqual(example.name, 'Example'); + }); - await t.test('It should handle reserved word value', () => { - class Example extends Enum { - static value = 1 - } - const example = Example.fromKey('value') + await t.test('It should handle reserved word value', () => { + class Example extends Enum { + static value = 1; + } + const example = Example.fromKey('value'); - assert.strictEqual(example.key, 'value') - assert.strictEqual(example.value, 1) - assert.deepEqual(example.values, [1]) - assert.deepEqual(Example.options, { - value: 1 - }) - assert.deepEqual(example.keys, ['value']) - assert.strictEqual(example.value, 1) - assert.strictEqual(example.length, 1) - }) + assert.strictEqual(example.key, 'value'); + assert.strictEqual(example.value, 1); + assert.deepEqual(example.values, [1]); + assert.deepEqual(Example.options, { + value: 1, + }); + assert.deepEqual(example.keys, ['value']); + assert.strictEqual(example.value, 1); + assert.strictEqual(example.length, 1); + }); - await t.test('It should handle reserved word options', () => { - class Example extends Enum { - static options = 42 - } - const example = Example.fromKey('options') + await t.test('It should handle reserved word options', () => { + class Example extends Enum { + static options = 42; + } + const example = Example.fromKey('options'); - assert.strictEqual(example.key, 'options') - assert.strictEqual(example.value, 42) - assert.deepEqual(example.values, [42]) - assert.strictEqual(Example.options, 42) - assert.deepEqual(example.keys, ['options']) - assert.strictEqual(example.options, 42) - assert.strictEqual(example.length, 1) - }) + assert.strictEqual(example.key, 'options'); + assert.strictEqual(example.value, 42); + assert.deepEqual(example.values, [42]); + assert.strictEqual(Example.options, 42); + assert.deepEqual(example.keys, ['options']); + assert.strictEqual(example.options, 42); + assert.strictEqual(example.length, 1); + }); - await t.test('It should handle reserved word is', () => { - class Example extends Enum { - static is = 42 - } - const example = Example.fromKey('is') + await t.test('It should handle reserved word is', () => { + class Example extends Enum { + static is = 42; + } + const example = Example.fromKey('is'); - assert.strictEqual(example.key, 'is') - assert.strictEqual(example.value, 42) - assert.deepEqual(example.values, [42]) - assert.deepEqual(Example.options, { - is: 42 - }) - assert.deepEqual(example.keys, ['is']) - assert.strictEqual(example.is, 42) - assert.strictEqual(example.length, 1) - assert.strictEqual(example.in([Example.options.is]), true) - assert.strictEqual(example.in([42]), true) - assert.strictEqual(example.in(['something']), false) - }) + assert.strictEqual(example.key, 'is'); + assert.strictEqual(example.value, 42); + assert.deepEqual(example.values, [42]); + assert.deepEqual(Example.options, { + is: 42, + }); + assert.deepEqual(example.keys, ['is']); + assert.strictEqual(example.is, 42); + assert.strictEqual(example.length, 1); + assert.strictEqual(example.in([Example.options.is]), true); + assert.strictEqual(example.in([42]), true); + assert.strictEqual(example.in(['something']), false); + }); - await t.test('It should handle reserved word in', () => { - class Example extends Enum { - static in = 42 - } - const example = Example.fromKey('in') + await t.test('It should handle reserved word in', () => { + class Example extends Enum { + static in = 42; + } + const example = Example.fromKey('in'); - assert.strictEqual(example.key, 'in') - assert.strictEqual(example.value, 42) - assert.deepEqual(example.values, [42]) - assert.deepEqual(Example.options, { - in: 42 - }) - assert.deepEqual(example.keys, ['in']) - assert.strictEqual(example.in, 42) - assert.strictEqual(example.length, 1) - assert.strictEqual(example.is(Example.in), true) - assert.strictEqual(example.is(42), true) - assert.strictEqual(example.is('something'), false) - }) + assert.strictEqual(example.key, 'in'); + assert.strictEqual(example.value, 42); + assert.deepEqual(example.values, [42]); + assert.deepEqual(Example.options, { + in: 42, + }); + assert.deepEqual(example.keys, ['in']); + assert.strictEqual(example.in, 42); + assert.strictEqual(example.length, 1); + assert.strictEqual(example.is(Example.in), true); + assert.strictEqual(example.is(42), true); + assert.strictEqual(example.is('something'), false); + }); - await t.test('It should throw an exception for an unknown value', () => { - try { - class Example extends Enum { - static keys = 1 - } - Example.fromKey('keys') - } catch (error) { - assert.strictEqual(error.message, 'Cannot set property keys of [object Object] which has only a getter') - } - }) + await t.test('It should throw an exception for an unknown value', () => { + try { + class Example extends Enum { + static keys = 1; + } + Example.fromKey('keys'); + } catch (error) { + assert.strictEqual( + error.message, + 'Cannot set property keys of [object Object] which has only a getter' + ); + } + }); - await t.test('It should throw an exception for an unknown value', () => { - try { - class Example extends Enum { - static values = 1 - } - Example.fromKey('values') - } catch (error) { - assert.strictEqual(error.message, 'Cannot set property values of [object Object] which has only a getter') - } - }) + await t.test('It should throw an exception for an unknown value', () => { + try { + class Example extends Enum { + static values = 1; + } + Example.fromKey('values'); + } catch (error) { + assert.strictEqual( + error.message, + 'Cannot set property values of [object Object] which has only a getter' + ); + } + }); - await t.test('It should overrule the options', () => { - class Example extends Enum { - static options = 1 - } - assert.strictEqual(Example.options, 1) - const example = Example.fromKey('options') - assert.deepEqual(example.values, [1]) + await t.test('It should overrule the options', () => { + class Example extends Enum { + static options = 1; + } + assert.strictEqual(Example.options, 1); + const example = Example.fromKey('options'); + assert.deepEqual(example.values, [1]); - Example.options = 42 - assert.strictEqual(Example.options, 42) - assert.deepEqual(example.values, [42]) + Example.options = 42; + assert.strictEqual(Example.options, 42); + assert.deepEqual(example.values, [42]); - Example.options2 = 2 - assert.strictEqual(Example.options, 42) - assert.strictEqual(Example.options2, 2) - assert.deepEqual(example.values, [42, 2]) - }) + Example.options2 = 2; + assert.strictEqual(Example.options, 42); + assert.strictEqual(Example.options2, 2); + assert.deepEqual(example.values, [42, 2]); + }); - await t.test('It should also work with multiple options', () => { - class Example extends Enum { - static 'test1' = 1 - static 'test2' = 2 - static 'test3' = 3 - } + await t.test('It should also work with multiple options', () => { + class Example extends Enum { + static test1 = 1; - const example = Example.create('test2') - assert.strictEqual(example.key, 'test2') - assert.strictEqual(example.value, 2) - assert.deepEqual(example.values, [1, 2, 3]) - assert.deepEqual(Example.options, { - test1: 1, - test2: 2, - test3: 3 - }) - assert.deepEqual(Example.toJSON(), { - test1: 1, - test2: 2, - test3: 3 - }) - assert.strictEqual(JSON.stringify(Example), '{"test1":1,"test2":2,"test3":3}') - assert.strictEqual(Example.test1, 1) - assert.strictEqual(Example.test2, 2) - assert.strictEqual(Example.test3, 3) - assert.strictEqual(Example.options.test2, 2) - assert.deepEqual(example.keys, ['test1', 'test2', 'test3']) - assert.strictEqual(example.test2, 2) - assert.strictEqual(example.length, 3) - assert.strictEqual(example.is(Example.test2), true) - assert.strictEqual(example.is(2), true) - assert.strictEqual(example.is('something'), false) - assert.strictEqual(example.in([Example.test2]), true) - assert.strictEqual(example.in([2]), true) - assert.strictEqual(example.in(['something']), false) - assert.strictEqual(example.valueOf(), 2) - assert.strictEqual(example.toString(), 'test2') - assert.strictEqual(example.toJSON(), 'test2') - assert.strictEqual(JSON.stringify(example), '"test2"') - }) + static test2 = 2; - await t.test('It should use the value for toString and toJSON', () => { - class Example extends Enum { - static 'test1' = 1 - static 'test2' = 2 - static 'test3' = 3 - } + static test3 = 3; + } - const example = Example.create('test2', { output: 'value' }) - assert.strictEqual(example.key, 'test2') - assert.strictEqual(example.value, 2) - assert.deepEqual(example.values, [1, 2, 3]) - assert.deepEqual(Example.options, { - test1: 1, - test2: 2, - test3: 3 - }) - assert.deepEqual(Example.toJSON(), { - test1: 1, - test2: 2, - test3: 3 - }) - assert.strictEqual(JSON.stringify(Example), '{"test1":1,"test2":2,"test3":3}') - assert.strictEqual(Example.test1, 1) - assert.strictEqual(Example.test2, 2) - assert.strictEqual(Example.test3, 3) - assert.strictEqual(Example.options.test2, 2) - assert.deepEqual(example.keys, ['test1', 'test2', 'test3']) - assert.strictEqual(example.test2, 2) - assert.strictEqual(example.length, 3) - assert.strictEqual(example.is(Example.test2), true) - assert.strictEqual(example.is(2), true) - assert.strictEqual(example.is('something'), false) - assert.strictEqual(example.in([Example.test2]), true) - assert.strictEqual(example.in([2]), true) - assert.strictEqual(example.in(['something']), false) - assert.strictEqual(example.valueOf(), 2) - assert.strictEqual(example.toString(), '2') - assert.strictEqual(example.toJSON(), 2) - assert.strictEqual(JSON.stringify(example), '2') - }) -}) + const example = Example.create('test2'); + assert.strictEqual(example.key, 'test2'); + assert.strictEqual(example.value, 2); + assert.deepEqual(example.values, [1, 2, 3]); + assert.deepEqual(Example.options, { + test1: 1, + test2: 2, + test3: 3, + }); + assert.deepEqual(Example.toJSON(), { + test1: 1, + test2: 2, + test3: 3, + }); + assert.strictEqual( + JSON.stringify(Example), + '{"test1":1,"test2":2,"test3":3}' + ); + assert.strictEqual(Example.test1, 1); + assert.strictEqual(Example.test2, 2); + assert.strictEqual(Example.test3, 3); + assert.strictEqual(Example.options.test2, 2); + assert.deepEqual(example.keys, ['test1', 'test2', 'test3']); + assert.strictEqual(example.test2, 2); + assert.strictEqual(example.length, 3); + assert.strictEqual(example.is(Example.test2), true); + assert.strictEqual(example.is(2), true); + assert.strictEqual(example.is('something'), false); + assert.strictEqual(example.in([Example.test2]), true); + assert.strictEqual(example.in([2]), true); + assert.strictEqual(example.in(['something']), false); + assert.strictEqual(example.valueOf(), 2); + assert.strictEqual(example.toString(), 'test2'); + assert.strictEqual(example.toJSON(), 'test2'); + assert.strictEqual(JSON.stringify(example), '"test2"'); + }); + + await t.test('It should use the value for toString and toJSON', () => { + class Example extends Enum { + static test1 = 1; + + static test2 = 2; + + static test3 = 3; + } + + const example = Example.create('test2', { output: 'value' }); + assert.strictEqual(example.key, 'test2'); + assert.strictEqual(example.value, 2); + assert.deepEqual(example.values, [1, 2, 3]); + assert.deepEqual(Example.options, { + test1: 1, + test2: 2, + test3: 3, + }); + assert.deepEqual(Example.toJSON(), { + test1: 1, + test2: 2, + test3: 3, + }); + assert.strictEqual( + JSON.stringify(Example), + '{"test1":1,"test2":2,"test3":3}' + ); + assert.strictEqual(Example.test1, 1); + assert.strictEqual(Example.test2, 2); + assert.strictEqual(Example.test3, 3); + assert.strictEqual(Example.options.test2, 2); + assert.deepEqual(example.keys, ['test1', 'test2', 'test3']); + assert.strictEqual(example.test2, 2); + assert.strictEqual(example.length, 3); + assert.strictEqual(example.is(Example.test2), true); + assert.strictEqual(example.is(2), true); + assert.strictEqual(example.is('something'), false); + assert.strictEqual(example.in([Example.test2]), true); + assert.strictEqual(example.in([2]), true); + assert.strictEqual(example.in(['something']), false); + assert.strictEqual(example.valueOf(), 2); + assert.strictEqual(example.toString(), '2'); + assert.strictEqual(example.toJSON(), 2); + assert.strictEqual(JSON.stringify(example), '2'); + }); +}); From bfd3121b3e8bcc1b3268b79a0ca9f23e536c7734 Mon Sep 17 00:00:00 2001 From: Pieter Wigboldus Date: Mon, 18 Dec 2023 22:17:50 +0100 Subject: [PATCH 2/3] Ignore some rules in the test file --- src/__tests__/enum.test.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/__tests__/enum.test.js b/src/__tests__/enum.test.js index 6d2f44c..3a6b46e 100644 --- a/src/__tests__/enum.test.js +++ b/src/__tests__/enum.test.js @@ -1,3 +1,5 @@ +/* eslint-disable max-statements */ +/* eslint-disable max-classes-per-file */ import test from 'node:test'; import assert from 'node:assert'; import { Enum } from '../enum.js'; From 60173b810d0b86d6e8857584a4907de2b12799e9 Mon Sep 17 00:00:00 2001 From: Pieter Wigboldus Date: Mon, 18 Dec 2023 22:18:11 +0100 Subject: [PATCH 3/3] Update the version --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index c0ba837..3289f7f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@hckrnews/enum", - "version": "3.0.0", + "version": "3.0.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@hckrnews/enum", - "version": "3.0.0", + "version": "3.0.1", "license": "MIT", "devDependencies": { "@hckrnews/eslint-code-quality": "^0.1.5", diff --git a/package.json b/package.json index 41ca04c..8dc8797 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "@hckrnews/enum", "description": "Create vanilla JavaScript enums", - "version": "3.0.0", + "version": "3.0.1", "author": { "name": "Pieter Wigboldus", "url": "https://hckr.news/"