Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize tests #673

Closed
Tracked by #720
ranocha opened this issue Jun 27, 2021 · 2 comments · Fixed by #809
Closed
Tracked by #720

Reorganize tests #673

ranocha opened this issue Jun 27, 2021 · 2 comments · Fixed by #809
Labels

Comments

@ranocha
Copy link
Member

ranocha commented Jun 27, 2021

Once #569 is resolved, I would prefer to structure the tests similarly.

@ranocha ranocha added the testing label Jul 7, 2021
@ranocha
Copy link
Member Author

ranocha commented Jul 7, 2021

We should also look at #372 when doing this reorganization. I did some very preliminary tests to see whether some order is preferrable.

julia> @time redirect_stdout(devnull) do # by equation
           run(`$(Base.julia_cmd()) -e 'include("examples/tree_2d_dgsem/elixir_advection_basic.jl");
                                        include("examples/tree_3d_dgsem/elixir_advection_basic.jl");
                                        include("examples/structured_2d_dgsem/elixir_advection_basic.jl");
                                        include("examples/structured_3d_dgsem/elixir_advection_basic.jl");'`)
           run(`$(Base.julia_cmd()) -e 'include("examples/tree_2d_dgsem/elixir_euler_ec.jl");
                                        include("examples/tree_3d_dgsem/elixir_euler_ec.jl");
                                        include("examples/structured_2d_dgsem/elixir_euler_ec.jl");
                                        include("examples/structured_3d_dgsem/elixir_euler_ec.jl");'`)
       end
164.508251 seconds (911.44 k allocations: 49.725 MiB, 0.00% gc time, 0.07% compilation time)

julia> @time redirect_stdout(devnull) do # by mesh
           run(`$(Base.julia_cmd()) -e 'include("examples/tree_2d_dgsem/elixir_advection_basic.jl");
                                        include("examples/tree_3d_dgsem/elixir_advection_basic.jl");
                                        include("examples/tree_2d_dgsem/elixir_euler_ec.jl");
                                        include("examples/tree_3d_dgsem/elixir_euler_ec.jl");'`)
           run(`$(Base.julia_cmd()) -e 'include("examples/structured_2d_dgsem/elixir_advection_basic.jl");
                                        include("examples/structured_3d_dgsem/elixir_advection_basic.jl");
                                        include("examples/structured_2d_dgsem/elixir_euler_ec.jl");
                                        include("examples/structured_3d_dgsem/elixir_euler_ec.jl");'`)
       end
147.843229 seconds (794.04 k allocations: 42.443 MiB, 0.00% gc time, 0.04% compilation time)

julia> @time redirect_stdout(devnull) do # by dimension
           run(`$(Base.julia_cmd()) -e 'include("examples/tree_2d_dgsem/elixir_advection_basic.jl");
                                        include("examples/tree_2d_dgsem/elixir_euler_ec.jl");
                                        include("examples/structured_2d_dgsem/elixir_advection_basic.jl");
                                        include("examples/structured_2d_dgsem/elixir_euler_ec.jl");'`)
           run(`$(Base.julia_cmd()) -e 'include("examples/tree_3d_dgsem/elixir_advection_basic.jl");
                                        include("examples/tree_3d_dgsem/elixir_euler_ec.jl");
                                        include("examples/structured_3d_dgsem/elixir_advection_basic.jl");
                                        include("examples/structured_3d_dgsem/elixir_euler_ec.jl");'`)
       end
145.176463 seconds (791.85 k allocations: 42.283 MiB, 0.00% gc time, 0.04% compilation time)

Based on these preliminary results, it looks like we shouldn't sort the tests by equations but by dimension/mesh.

@sloede
Copy link
Member

sloede commented Jul 8, 2021

Thanks for testing this out! If the optimal sorting matches (or is close to) the alphabetical ordering of the example folders, it would be nice to retain the same order and get extra karma for staying consistent!

@ranocha ranocha mentioned this issue Jul 13, 2021
36 tasks
@ranocha ranocha mentioned this issue Aug 20, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants