Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe switch to mappings that accept vectors/tuples for CurvedMesh/P4estMesh #602

Closed
efaulhaber opened this issue May 24, 2021 · 2 comments

Comments

@efaulhaber
Copy link
Member

    node_coordinates[:, i, j, tree] .= mapping(node_coordinates[1, i, j, tree],
                                               node_coordinates[2, i, j, tree])

I wonder whether we should switch to mappings that accept the coordinates as a single SVector/Tuple/AbstractVector/iterable... Then, we could just use identity for the identity mapping... However, this won't block this PR and we might continue this discussion elsewhere.

Originally posted by @ranocha in #598 (comment)

@ranocha ranocha added triage To be decided at the next Trixi meeting and removed triage To be decided at the next Trixi meeting labels Jul 7, 2021
@ranocha
Copy link
Member

ranocha commented Jul 13, 2021

Triage: Mappings should accept the coordinates bundled in a tuple/vector

@ranocha ranocha mentioned this issue Jul 13, 2021
36 tasks
@ranocha
Copy link
Member

ranocha commented Jul 27, 2021

After a closer look at the source code, I don't think this change is really necessary. We would need to wrap and unwrap everything without gaining much. In addition, it's easier to distinguish 2D and 3D mappings using the current signature. Thus, let's not make this breaking change now.

@ranocha ranocha closed this as completed Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants