Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the type constraint orientation::Integer to every flux function #506

Closed
NichtLucas opened this issue Apr 4, 2021 · 1 comment · Fixed by #550
Closed

Add the type constraint orientation::Integer to every flux function #506

NichtLucas opened this issue Apr 4, 2021 · 1 comment · Fixed by #550

Comments

@NichtLucas
Copy link
Contributor

As discussed here, we should probably add the type constraint orientation::Integer to every flux function to distinguish normal vectors and orientations.

@ranocha
Copy link
Member

ranocha commented Apr 4, 2021

The second part of this issue is to (possibly?) get rid of FluxRotated and create some syntactic sugar to generate the necessary methods specialized on normal::AbstractVector instead of orientation::Integer. A simple macro should do the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants