Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure is not called unless a component is public. #183

Open
arnecls opened this issue Jul 20, 2017 · 1 comment
Open

Configure is not called unless a component is public. #183

arnecls opened this issue Jul 20, 2017 · 1 comment
Milestone

Comments

@arnecls
Copy link
Contributor

arnecls commented Jul 20, 2017

During the check for struct tags, nested components are iterated, too (if they are not pointers).
If a component has a configure method it is called. However this does only work if the component is public.

type Foo struct {
    sub1 Component // Configure is not called
    Sub2 Component // Configure is called
}

See if there is a way to make this work on private members, too.

@arnecls arnecls added the bug label Jul 20, 2017
@arnecls
Copy link
Contributor Author

arnecls commented Jul 24, 2017

As a sidenote: Due to the embedded structs being public they show up in the godocs documentation. This is important as configuration parameters are inherited but not shown in the godocs pages. Clicking on the embedded members somewhat solves this problem.

@arnecls arnecls added enhancement and removed bug labels Jul 24, 2017
@arnecls arnecls added this to the v0.6.0 milestone Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant