Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

histogram allows the creation of non-power-of-two tensor sizes #4826

Open
saagarjha opened this issue Sep 29, 2024 · 0 comments
Open

histogram allows the creation of non-power-of-two tensor sizes #4826

saagarjha opened this issue Sep 29, 2024 · 0 comments

Comments

@saagarjha
Copy link

The histogram function takes a parameter for the number of bins it should collect results in, then returns a tensor of that size. Unfortunately it has no checks on what this parameter is, so you can pass in a number that is not a power of two and get a broken tensor back. I say broken because Triton actively tries to obviate these existing in the first place, and you cannot actually operate on these tensors–every other operation will reject it for size mismatch, including the functions that would allow for changing its shape. So it doesn't really make sense to allow the creation of these at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant