Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleaner 'all' menu with extmarks and nice mode lists #25

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

willothy
Copy link
Collaborator

image

lua/hawtkeys/ui.lua Outdated Show resolved Hide resolved
@tris203
Copy link
Owner

tris203 commented Dec 20, 2023

This looks great @willothy !

Thank you, do you think there is any reason that we cant use this as a general theme accross the whole plugin?

@tris203 tris203 self-requested a review December 20, 2023 09:26
@willothy
Copy link
Collaborator Author

This looks great @willothy !

Thank you, do you think there is any reason that we cant use this as a general theme accross the whole plugin?

Thanks! I can do some work with extmarks and highlighting for the rest of the UI, and try to unify things a bit. For example, I'd like to use overlay extmarks for the search character highlights instead of [char]

@tris203
Copy link
Owner

tris203 commented Dec 20, 2023

This looks great @willothy !
Thank you, do you think there is any reason that we cant use this as a general theme accross the whole plugin?

Thanks! I can do some work with extmarks and highlighting for the rest of the UI, and try to unify things a bit. For example, I'd like to use overlay extmarks for the search character highlights instead of [char]

would you like to do that in this PR or a seperate one? @willothy

@willothy
Copy link
Collaborator Author

Probably a separate one, since this code likely won't be changed in it

@tris203 tris203 merged commit 39f4f96 into tris203:main Dec 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants