Collect stats on <style> in <body>

Relates to whatwg/html#1605
tripu · Aug 19, 2016 · 99b09f0 · 99b09f0
1 parent c10de32
commit 99b09f0
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/src/nu/validator/servlet/Statistics.java b/src/nu/validator/servlet/Statistics.java
@@ -117,6 +117,7 @@ public enum Field {
                 "XHTML output"), OUTPUT_XML("XML output"), OUTPUT_JSON(
                 "JSON output"), OUTPUT_GNU("GNU output"), OUTPUT_TEXT(
                 "Text output"), INPUT_HTML("HTML input"), INPUT_XML("XML input"),
+                STYLE_IN_BODY_FOUND("<style> in <body> found"),
                 LANG_FOUND("<html lang> found"),
                 LANG_WRONG("<html lang> does not match detected language"),
                 LANG_EMPTY("<html lang>: empty (lang=\"\")"),

diff --git a/src/nu/validator/servlet/VerifierServletTransaction.java b/src/nu/validator/servlet/VerifierServletTransaction.java
@@ -1224,6 +1224,12 @@ private void gatherStatistics() {
             } else if (externalSchematron) {
                 stats.incrementField(Statistics.Field.LOGIC_ERROR);
             }
+            if (request.getAttribute(
+                    "http://validator.nu/properties/style-in-body-found") != null
+                    && (boolean) request.getAttribute(
+                            "http://validator.nu/properties/style-in-body-found")) {
+                stats.incrementField(Statistics.Field.STYLE_IN_BODY_FOUND);
+            }
             if (request.getAttribute(
                     "http://validator.nu/properties/lang-found") != null
                     && (boolean) request.getAttribute(

diff --git a/src/nu/validator/xml/LanguageDetectingXMLReaderWrapper.java b/src/nu/validator/xml/LanguageDetectingXMLReaderWrapper.java
@@ -191,6 +191,9 @@ public void endElement(String uri, String localName, String qName)
             documentContent.append(elementContent);
             elementContent.setLength(0);
         }
+        if ("body".equals(localName)) {
+            inBody = true;
+        }
         contentHandler.endElement(uri, localName, qName);
     }
 
@@ -231,6 +234,12 @@ public void startElement(String uri, String localName, String qName,
                     dirAttrValue = atts.getValue(i);
                 }
             }
+        } else if ("style".equals(localName)) {
+            if (inBody && request != null) {
+                request.setAttribute(
+                        "http://validator.nu/properties/style-in-body-found",
+                        true);
+            }
         } else if ("body".equals(localName)) {
             inBody = true;
         }