Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obnoxious behavior if > 500 results #25

Open
bradfordcondon opened this issue Feb 27, 2018 · 5 comments
Open

obnoxious behavior if > 500 results #25

bradfordcondon opened this issue Feb 27, 2018 · 5 comments
Assignees
Labels
bug - confirmed For issues where a maintainer has confirmed a bug exists. Maintainer - Previous Version Any issues that were filed on other versions of this module that we are not sure apply anymore.

Comments

@bradfordcondon
Copy link
Member

bradfordcondon commented Feb 27, 2018

A user was confused because their blast results had over 500 results, and therefore no results were displayed.

statonlab/hardwoods_site#199

After some fiddling I discovered that you can set the max target sequences in the advanced options to return 500 or fewer sequences (see below).

Rather than return no results, why not return the first 500 results and display a warning that there are more results?

default blast parameters: error, 500+ sequences

screen shot 2018-02-27 at 11 58 01 am

max target = 50

screen shot 2018-02-27 at 12 00 07 pm

edit:
Also, the error message reads

We have provided the result files for Download at the top of this page; however, we suggest you re-submit your query using a more stringent e-value (i.e. a smaller number).

However, no download link is provided. Note that the link is provided if < 500 entries

@ekcannon
Copy link
Collaborator

It's great to have more people using this module so that annoyances like this can be identified and addressed. As I wrote the code to bail if >500 results (a quick solution to a problem that was holding up a website release), I'll tackle improved handling of large results sets.

@ekcannon ekcannon self-assigned this Feb 27, 2018
@bradfordcondon
Copy link
Member Author

As I wrote the code to bail if >500 results (a quick solution to a problem that was holding up a website release), I'll tackle improved handling of large results sets.

Great and thank you! IMO This module works great and is easy to administer so I'm a big fan. I'd be happy to contribute as well.

Cheers

@bradfordcondon
Copy link
Member Author

Oh i forgot the second part of this issue:

The error reads

We have provided the result files for Download at the top of this page; however, we suggest you re-submit your query using a more stringent e-value (i.e. a smaller number).

However, on my site at least, no download link is provided.

@laceysanderson
Copy link
Member

Part of the issue with >500 results is the XML reader this module is using. It reads the entire file into memory resulting in a WSOD for large files. The solution is to switch to a stream-based XML reader as suggested in Issue #12.

The lack of download files is a simple bug however that should be easy to fix :-)

@bradfordcondon
Copy link
Member Author

bradfordcondon commented Feb 27, 2018

woops sorry for creating an issue largely duplicate with #12

embarrassing considering theres only 2 other issues lol

@laceysanderson laceysanderson added bug - confirmed For issues where a maintainer has confirmed a bug exists. Maintainer - Previous Version Any issues that were filed on other versions of this module that we are not sure apply anymore. labels Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug - confirmed For issues where a maintainer has confirmed a bug exists. Maintainer - Previous Version Any issues that were filed on other versions of this module that we are not sure apply anymore.
Projects
None yet
Development

No branches or pull requests

3 participants