Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error and warning handling #239

Open
bradfordcondon opened this issue Sep 20, 2018 · 3 comments
Open

error and warning handling #239

bradfordcondon opened this issue Sep 20, 2018 · 3 comments

Comments

@bradfordcondon
Copy link
Member

Errors vs exiting etc is handled inconsistently. Convert all print/exit statements to warnigns provided by the importer class:

see https://tripal.readthedocs.io/en/latest/dev_guide/custom_data_loader.html?highlight=warnings

@almasaeed2010
Copy link
Contributor

did we fix this for test suite?

@bradfordcondon
Copy link
Member Author

short story, this is a core problem.
tripal/tripal#588

i think that i started working on it but didnt see the point with how its currently set up.

@bradfordcondon bradfordcondon removed their assignment Apr 9, 2019
@bradfordcondon
Copy link
Member Author

  • no exits in expression loader/biomaterial loader

We still use print though, especially in hte expression loader. the biomaterial loader has most messages changed to API calls like so:

      tripal_report_error('tripal_biomaterial_loader', TRIPAL_ERROR, $message, ['!path' => $file_path], ['print' => TRUE]);

I'm not sure why we're doing that instead of using $this->logMessage()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants