We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors vs exiting etc is handled inconsistently. Convert all print/exit statements to warnigns provided by the importer class:
see https://tripal.readthedocs.io/en/latest/dev_guide/custom_data_loader.html?highlight=warnings
The text was updated successfully, but these errors were encountered:
did we fix this for test suite?
Sorry, something went wrong.
short story, this is a core problem. tripal/tripal#588
i think that i started working on it but didnt see the point with how its currently set up.
We still use print though, especially in hte expression loader. the biomaterial loader has most messages changed to API calls like so:
tripal_report_error('tripal_biomaterial_loader', TRIPAL_ERROR, $message, ['!path' => $file_path], ['print' => TRUE]);
I'm not sure why we're doing that instead of using $this->logMessage()?
$this->logMessage()
No branches or pull requests
Errors vs exiting etc is handled inconsistently. Convert all print/exit statements to warnigns provided by the importer class:
see https://tripal.readthedocs.io/en/latest/dev_guide/custom_data_loader.html?highlight=warnings
The text was updated successfully, but these errors were encountered: