Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Playwright #13

Open
Lonli-Lokli opened this issue May 16, 2020 · 4 comments
Open

Add support for Playwright #13

Lonli-Lokli opened this issue May 16, 2020 · 4 comments
Assignees

Comments

@Lonli-Lokli
Copy link

Add support for Playwright
https://github.com/microsoft/playwright

@everflux
Copy link
Contributor

Thanks for raising this issue.
I am not sure that playwright would be a good fit for this image. The idea was to offer the canonical tools for angular based development as Docker images especially for ci builds.

How would you use playwright in your build? How do you feel about using a separate image that provides playwright in your build?

@everflux everflux self-assigned this May 16, 2020
@Lonli-Lokli
Copy link
Author

@everflux Unfortunately Protractor seems to be abandoned https://github.com/angular/protractor/commits/master

So I'm looking for another options for angular apps, like cypress or more promising Playwright.
Actually I will it use similar like it's now with Protractor - Angular CLI based app, set of scripts and new E2E tooling.
I do not have enought knowledge as of now to create such image but IMO it's completely ok to have it in a separate image.

@everflux
Copy link
Contributor

I don't think that protractor is abandoned, and can't conclude that from the commits to master which show recent progress.
If you want to use a different tool for e2e tests, than protractor, for example puppeteer, cypress or playwright I suggest that you use a separate image in your CI pipeline.
For example use trion/ng-cli(-karma) for building and unit testing and a cypress image for e2e tests.

I could not find available playwright images on dockerhub, I will look into providing a build. But this would be separate from the Angular tooling images. Would that work for you?

@Lonli-Lokli
Copy link
Author

There are 17 commits in 2020 (I believe that's just because Angular drops support for older Node), 2 commits in 2019 and 43 commits in 2018 - as for me it's pretty close to not-maintained project :)

Yep, I saw your images, thanks for them! As of now I'm going to use Jest for unit testing and cypress\playwright for e2e.

Separate image would be totally fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants