Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement okapi_version() check everywhere #423

Closed
8 of 9 tasks
fundthmcalculus opened this issue May 18, 2022 · 2 comments · Fixed by #426
Closed
8 of 9 tasks

Implement okapi_version() check everywhere #423

fundthmcalculus opened this issue May 18, 2022 · 2 comments · Fixed by #426
Assignees

Comments

@fundthmcalculus
Copy link
Contributor

fundthmcalculus commented May 18, 2022

Implement the okapi version function as implemented here: #422

Languages:

  • Dart
  • .NET
  • Go
  • Java
  • Node
  • Python
  • Ruby
  • Swift
  • Wasm
@fundthmcalculus fundthmcalculus self-assigned this May 18, 2022
@tmarkovski
Copy link
Member

Let's schedule this for sometime after GA

@fundthmcalculus
Copy link
Contributor Author

My plan is to have this for better debugging support. We can ensure customers are using the native binary version that we think they are using. Mostly this applies to mobile, where you can't pull the native binary metadata to determine version number.

I'd rather get this out with the 1.6 release so that we can start using it if necessary. It's a trivial change, separate from the discussion surrounding how to version the wrapper libraries (which can be done close-to or post GA).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants