Fix build inside git worktrees by working around git-commit-id #639

[xkrogen]

Description

Explicitly configure the dotGitDirectory used by the git-commit-id-maven-plugin to be the root of the (multi-module) project using the air.main.basedir property.

This is needed when using git worktrees, as the plugin incorrectly detects the wrong directory in which to run git commands. If git-commit-id/git-commit-id-maven-plugin#639 or git-commit-id/git-commit-id-maven-plugin#215 are resolved, this will become unnecessary. When Trino upgrades to Maven 4.0.0, assuming the workaround is still needed, we can update to using the new project.rootDirectory property (see MNG-7038) instead of the Airbase one.

Additional context and related issues

This fixes #18027; see the discussion there for more details.

Release notes

(X) This is not user-visible or docs only and no release notes are required.

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[xkrogen]

Looks like the trino-hive test failed on something flaky; it succeeded in the previous run (which was identical except for being split into two commits rather than being squashed):

Error:  Tests run: 3855, Failures: 1, Errors: 0, Skipped: 154, Time elapsed: 1,894.981 s <<< FAILURE! - in TestSuite
Error:  io.trino.plugin.hive.TestHiveConnectorTest.testWriterTasksCountLimitPartitionedScaleWritersEnabled  Time elapsed: 11.929 s  <<< FAILURE!
java.lang.AssertionError: expected [2] but found [4]

I sent in my CLA a couple of days ago but haven't heard back yet.

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[wendigo]

Please squash commits into single one @xkrogen

[xkrogen]

Done! Thanks @wendigo

[wendigo]

@xkrogen I'll merge this change when tests are completed

[wendigo]

@xkrogen thanks for the fix and congratulations on your first contribution to Trino 🎉

[xkrogen]

Woohoo! :)