Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SchemaTableName should not be required for synthetic ConnectorTableHandle returned from ConnectorMetadata.apply methods #6694

Open
findepi opened this issue Jan 22, 2021 · 0 comments
Open

SchemaTableName should not be required for synthetic ConnectorTableHandle returned from ConnectorMetadata.apply methods #6694

findepi opened this issue Jan 22, 2021 · 0 comments

Comments

@findepi
Copy link
Member

findepi commented Jan 22, 2021

ConnectorTableMetadata io.trino.spi.connector.ConnectorMetadata#getTableMetadata needs to be implemented for any ConnectorTableHandle that participates in the query.

However, the it requires that ConnectorTableMetadata.schemaTableName is set.
This does not play well with synthetic table handles as returned from io.trino.spi.connector.ConnectorMetadata#applyAggregation, io.trino.spi.connector.ConnectorMetadata#applyTopN or io.trino.spi.connector.ConnectorMetadata#applyJoin.

We should make ConnectorTableMetadata.schemaTableName optional, or introduce a different API that does not require 'inventing' schema table names.
@findepi findepi mentioned this issue Jan 22, 2021
Open
@findepi findepi changed the title ConnectorTableMetadata.schemaTableName should be optional SchemaTableName should not be required for synthetic ConnectorTableHandle returned from ConnectorMetadata.apply methods Jan 22, 2021
This was referenced Jan 22, 2021
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@findepi