Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MySQL datetime data type #5449

Closed
findepi opened this issue Oct 7, 2020 · 2 comments
Closed

Add support for MySQL datetime data type #5449

findepi opened this issue Oct 7, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@findepi
Copy link
Member

findepi commented Oct 7, 2020 •
edited
Loading

See TODO comment in
https://github.com/prestosql/presto/blob/50a87c711f7967772cab0d6fb70f9e2810ff5587/presto-mysql/src/test/java/io/prestosql/plugin/mysql/TestMySqlTypeMapping.java#L437-L442

// TODO MySQL datetime is not correctly read (see comment in StandardColumnMappings.timestampColumnMappingUsingSqlTimestamp)
// testing this is hard because of https://github.com/prestosql/presto/issues/37

(the referenced issue (#37) is generally done)

rel #6910
@findepi findepi added the enhancement New feature or request label Oct 7, 2020
@findepi findepi changed the title Ad support for MySQL datetime data type Add support for MySQL datetime data type Oct 7, 2020
This was referenced Oct 7, 2020
Open
Closed
@findepi
Copy link
Member Author

findepi commented Oct 7, 2020

See also TODO in the code (being added in #5455)

@jirassimok jirassimok mentioned this issue Mar 9, 2021
Merged
@findepi findepi mentioned this issue Mar 9, 2021
Closed
@hashhar
Copy link
Member

hashhar commented Jun 28, 2021

Fixed by merging #8060. MySQL connector now uses java.time API avoiding the DST related issues.

@hashhar hashhar closed this as completed Jun 28, 2021
@hashhar hashhar mentioned this issue Jun 28, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@findepi @hashhar