-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StripeSetupIntent.isSuccess coming back as false in iOS #130
Comments
Can you try |
@triniwiz I removed the old version node module folder and upgraded to that version and the issue is still there in iOS |
Ok |
upgraded to beta-1 and get this error on ns run ios: ERROR in ../node_modules/@triniwiz/nativescript-stripe/angular/index.ts ERROR in ../node_modules/@triniwiz/nativescript-stripe/index.ts |
That one was on me 😂 use |
@triniwiz I updated to beta 2 and now I get this error on ns run ios (it never deploys to my iphone) error: There is no XCFramework found at '/Users/gonzalo/Repos/BoxGo-customer-mobile/node_modules/@triniwiz/nativescript-stripe/platforms/ios/Stripe.xcframework'. ** ARCHIVE FAILED ** I then went back to alpha13 and same error (alpha13 used to work just fine). then I noticed beta 3 is out but getting the same error. I am not sure if it's my environment somehow or the plug in. I didn't change anything other than the plug in version.. |
@triniwiz nevermind my comment above, I wiped out all npm modules to start from scratch and beta 3 builds and runs fine. However the issue about isSuccess coming back as false is still there in iOS. |
Can you try |
@triniwiz A snippet of what I am doing stripe.createPaymentMethod(this.creditCardView.cardParams, (error, pm) => { And the console output: (this is a stripe test env so I didn't bother to remove any of the tokens..) `==== object dump start ==== ` |
Nice just as I thought can you try |
So this has never worked. I downloaded ver 7.0.0 and the isSuccess flag is false even when the credit card entered was created successfully |
I followed the demo angular tutorial to allow user to store payment method (credit card) on stripe and it works successfully in both iOS and android - I can see the card becoming visible in stripe dashboard and all event logs as expected with a "succeeded" on all statuses that I can see.
However on the last call I am using StripeSetupInten.isSuccess property as a signal that everything went ok to close my modal that has CreditCardView in it. In android this is coming back as true, but in iOS it's coming back as false, and I'm not sure why given everything went fine behind the scenes.
Below is snippet of relevant code. The method at the bottom handles the last bit of the process and you can see where I depend on the isSuccess property. Like I said all logs I see from these calls in stripe are good and the card is being added as expected, but isSuccess is coming back false in iOS. Once I close out of my modal manually and refresh a list view I have as the parent I can actually retrieve the credit card that was just added.
If there's no immediate fix, is there any other indicator I can use to ensure everything went ok in iOS?
`onSave(cardView: CreditCardView) {
this.creditCardView = cardView;
this.setupIntentSecret$ = this.paymentFormService.getPaymentMethodSetupIntentSecret(this.user.userId);
this.subscribeToSetupIntent();
}
my package.json
{
"name": "@nativescript/template-tab-navigation-ng",
"main": "main.js",
"displayName": "Tabs",
"templateType": "App template",
"version": "7.0.6",
"description": "NativeScript Application",
"author": "NativeScript Team [email protected]",
"license": "SEE LICENSE IN ",
"publishConfig": {
"access": "public"
},
"keywords": [
"nstudio",
"nativescript",
"mobile",
"angular",
"{N}",
"tns",
"template",
"tab",
"navigation",
"category-general"
],
"repository": "",
"homepage": "https://github.com/NativeScript/nativescript-app-templates",
"bugs": {
"url": "https://github.com/NativeScript/NativeScript/issues"
},
"scripts": {
"lint": "tslint "src/**/*.ts""
},
"dependencies": {
"@angular/animations": "~11.0.0",
"@angular/common": "~11.0.0",
"@angular/compiler": "~11.0.0",
"@angular/core": "~11.0.0",
"@angular/forms": "~11.0.0",
"@angular/platform-browser": "~11.0.0",
"@angular/platform-browser-dynamic": "~11.0.0",
"@angular/router": "~11.0.0",
"@nativescript/angular": "~11.0.0",
"@nativescript/camera": "^5.0.8",
"@nativescript/core": "~7.1.0",
"@nativescript/firebase": "^11.1.3",
"@nativescript/theme": "~2.3.0",
"@triniwiz/nativescript-stripe": "^7.0.0-alpha13",
"reflect-metadata": "~0.1.12",
"rxjs": "^6.6.0",
"zone.js": "~0.11.1"
},
"devDependencies": {
"@angular/compiler-cli": "~11.0.0",
"@nativescript/android": "7.0.1",
"@nativescript/ios": "7.1.1",
"@nativescript/webpack": "~4.0.0",
"@ngtools/webpack": "~11.0.0",
"codelyzer": "~6.0.0",
"node-sass": "^4.14.1",
"tslint": "~6.1.3",
"typescript": "~4.0.0"
},
"private": "true",
"readme": "NativeScript Application"
}
The text was updated successfully, but these errors were encountered: