Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report for trillium-http: Tests fail when not specifying any features #362

Closed
divergentdave opened this issue Aug 22, 2023 · 0 comments · Fixed by #363
Closed

Bug report for trillium-http: Tests fail when not specifying any features #362

divergentdave opened this issue Aug 22, 2023 · 0 comments · Fixed by #363
Labels
bug Something isn't working

Comments

@divergentdave
Copy link
Contributor

Describe the bug
The library-level doctest in trillium-http creates a TCP server using async-net, and connects to it using trillium_testing::ClientConfig. This works when any of the features trillium-testing/tokio, trillium-testing/smol, or trillium-testing/async-std are enabled, but fails when none of these features are enabled, because it uses the in-memory RuntimelessClientConfig, which does not touch the network. The CI runs tests with each of these features enabled, but not with default features.

To Reproduce
Steps to reproduce the behavior:

  1. Run cargo test
@divergentdave divergentdave added the bug Something isn't working label Aug 22, 2023
@jbr jbr mentioned this issue Aug 22, 2023
Merged
@jbr jbr closed this as completed in #363 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Http doctest no features trillium-rs/trillium
1 participant
@divergentdave