Trillium
Add support for sending a file #112
Replies: 2 comments 8 replies
-
|
Converted to a discussion, as this is potentially a new handler / crate, specifically if the static file handler doesn't work for you. |
Beta Was this translation helpful? Give feedback.
-
|
For now I created a small util function. /// requires async-fs (smol) crate
pub async fn body_from_path<P: AsRef<std::path::Path>>(path: P) -> std::io::Result<Body> {
use async_fs::{self as fs, File};
let file = File::open(&path).await?;
let len = fs::metadata(&path).await?.len();
Ok(Body::new_streaming(file, Some(len)))
}
/// requires mime_guess crate
pub async fn body_from_path_with_mime<P: AsRef<std::path::Path>>(
path: P,
) -> std::io::Result<(Body, String)> {
Ok((
body_from_path(&path).await?,
mime_guess::from_path(&path)
.first_or_octet_stream()
.to_string(),
))
}Then one can use it as let (body, content_type) =
conn_try!(body_from_path_with_mime("/tmp/file").await, conn);
conn.with_header(KnownHeaderName::CacheControl, "max-age=31536000") // 1 year as a second
.with_header(KnownHeaderName::ContentType, content_type)
.ok(body)The only problem is I get a random number in response body. Not sure what 25 is and seems to be truncating text. Original file content is |
Beta Was this translation helpful? Give feedback.
-
|
Seems like if I use |
Beta Was this translation helpful? Give feedback.
-
|
This is fixed on main, will release today. Your code is correct. |
Beta Was this translation helpful? Give feedback.
-
|
What is the recommended way to create an use async_fs::{self as fs, File};
#[trillium::async_trait]
pub trait SendFileConnExt {
async fn send_file<P: AsRef<Path>>(mut self, path: P) -> Self;
}
#[trillium::async_trait]
impl SendFileConnExt for Conn {
async fn send_file<P: AsRef<Path>>(mut self, path: P) -> Self {
let file = conn_try!(File::open(&path).await, self);
let metadata = conn_try!(fs::metadata(&path).await, self);
let len = metadata.len();
self.with_body(Body::new_streaming(file, Some(len)))
.with_status(200)
}
} |
Beta Was this translation helpful? Give feedback.
-
|
I have now published the trillium-send-file crate. You can use Usage: use trillium::Conn;
use trillium_send_file::SendFileConnExt;
fn main() {
trillium_smol::run(|conn: Conn| async move {
conn.send_file("/tmp/file.txt".into()).await
});
} |
Beta Was this translation helpful? Give feedback.
-
|
Cool, nice work! I've been working on some changes to trillium-static that overlap with this, but it's good for the ecosystem to have several options |
Beta Was this translation helpful? Give feedback.
-
|
Just saw your PR, seems like it has almost all the features I wanted to implement in my send file. I was hoping to work on etag support in the upcoming weeks but seems like you have already implemented. I will move to your library. Do you also plan to support range requests so clients can support resuming downloads or downloading in chunks? Wondering if trillium needs Unrelated to this thread but what are your plans on supporting multipart uploads? |
Beta Was this translation helpful? Give feedback.
-
|
(wrote this as a distinct comment and lost the first version when I moved it to a reply) Yes to both of these, it's just a matter of order. Range requests (and an associated feature, http trailers for content-based etags on streaming bodies) require changes to the Multipart I had figured was low priority because I wasn't sure if anyone actually used html forms directly these days without js, but probably could be convinced to prioritize it. Unlike range requests, it wouldn't require any changes to the |
Beta Was this translation helpful? Give feedback.
-
|
Not in hurry for range requests yet so this can come later. Multipart would be needed if one want to implement it using pure html forms and server side without javascript. If we want to pass additional metadata about the file I would also want to use multipart even if it is via ajax. While one could use a rest api and then add headers I would like to have a a url such as |
Beta Was this translation helpful? Give feedback.
-
I have been working on porting a tide app to use trillium and noticed that there is no way to send a single file. Closest I found was
StaticFileHandler.I'm looking for an alternative for
Body::from_file().Beta Was this translation helpful? Give feedback.
All reactions